Bug 148093 - Simplify how PlatformWebViews are created when view options change
Summary: Simplify how PlatformWebViews are created when view options change
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 148154 148528 148529 148927
Blocks:
  Show dependency tree / graph
 
Reported: 2015-08-17 14:17 PDT by Anders Carlsson
Modified: 2015-09-07 04:46 PDT (History)
2 users (show)

See Also:

Attachments
Patch (12.12 KB, patch)
2015-08-17 14:31 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (12.29 KB, patch)
2015-08-17 14:58 PDT, Anders Carlsson 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-08-17 14:17:38 PDT 
Simplify how PlatformWebViews are created when view options change
Comment 1 Anders Carlsson 2015-08-17 14:31:04 PDT 
Created attachment 259184 [details]
Patch
Comment 2 Anders Carlsson 2015-08-17 14:58:21 PDT 
Created attachment 259193 [details]
Patch
Comment 3 Anders Carlsson 2015-08-17 15:49:46 PDT 
Committed r188548: <http://trac.webkit.org/changeset/188548>
Comment 4 Csaba Osztrogonác 2015-09-07 04:45:50 PDT 
Comment on attachment 259193 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259193&action=review

> Tools/WebKitTestRunner/TestController.cpp:755
> -    if (test.urlContains("device-adapt/") || test.urlContains("device-adapt\\"))
> -        return true;
> +        if (test.urlContains("device-adapt/") || test.urlContains("device-adapt\\"))
> +            return true;

bad indentation

> Tools/WebKitTestRunner/efl/TestControllerEfl.cpp:144
> +static bool shouldUseFixedLayout(const TestInvocation& test)
> +{
> +#if USE(COORDINATED_GRAPHICS)
> +    if (test.urlContains("sticky/") || test.urlContains("sticky\\"))
> +        return true;
> +#endif
> +    return false;
> +}
> +

It is obviously wrong, because it returns false for device-adapt tests.
Comment 5 Csaba Osztrogonác 2015-09-07 04:46:29 PDT 
(In reply to comment #4)
> Comment on attachment 259193 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259193&action=review
> 
> > Tools/WebKitTestRunner/TestController.cpp:755
> > -    if (test.urlContains("device-adapt/") || test.urlContains("device-adapt\\"))
> > -        return true;
> > +        if (test.urlContains("device-adapt/") || test.urlContains("device-adapt\\"))
> > +            return true;
> 
> bad indentation
> 
> > Tools/WebKitTestRunner/efl/TestControllerEfl.cpp:144
> > +static bool shouldUseFixedLayout(const TestInvocation& test)
> > +{
> > +#if USE(COORDINATED_GRAPHICS)
> > +    if (test.urlContains("sticky/") || test.urlContains("sticky\\"))
> > +        return true;
> > +#endif
> > +    return false;
> > +}
> > +
> 
> It is obviously wrong, because it returns false for device-adapt tests.

Please check bug148927 which tries to fix the regression this patch caused.