148912 – [Mac] Add a mock AppleTV device for testing

Bug 148912 - [Mac] Add a mock AppleTV device for testing

Summary: [Mac] Add a mock AppleTV device for testing

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Media (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Eric Carlson

URL:
Keywords:	InRadar

Depends on:
Blocks:	148958
	Show dependency tree / graph

Reported:	2015-09-06 12:27 PDT by Eric Carlson
Modified:	2016-01-25 07:38 PST (History)
CC List:	7 users (show)

See Also:

Attachments
Proposed patch. (88.54 KB, patch) 2015-09-06 13:10 PDT, Eric Carlson	buildbot: commit-queue-	Details \| Formatted Diff \| Diff
Archive of layout-test-results from ews106 for mac-mavericks-wk2 (667.40 KB, application/zip) 2015-09-06 13:56 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews101 for mac-mavericks (591.87 KB, application/zip) 2015-09-06 14:11 PDT, Build Bot	no flags	Details
Updated patch. (89.38 KB, patch) 2015-09-06 15:19 PDT, Eric Carlson	no flags	Details \| Formatted Diff \| Diff
Updated patch. (89.30 KB, patch) 2015-09-06 16:17 PDT, Eric Carlson	no flags	Details \| Formatted Diff \| Diff
YAUP. (89.41 KB, patch) 2015-09-06 16:54 PDT, Eric Carlson	no flags	Details \| Formatted Diff \| Diff
Patch for landing. (89.55 KB, patch) 2015-11-09 12:43 PST, Eric Carlson	commit-queue: commit-queue-	Details \| Formatted Diff \| Diff
Updated patch for landing. (89.38 KB, patch) 2015-11-09 16:37 PST, Eric Carlson	commit-queue: commit-queue-	Details \| Formatted Diff \| Diff
One more time? (92.95 KB, patch) 2015-11-09 18:00 PST, Eric Carlson	commit-queue: commit-queue-	Details \| Formatted Diff \| Diff
Another patch for landing. (92.93 KB, patch) 2015-11-09 18:07 PST, Eric Carlson	commit-queue: commit-queue-	Details \| Formatted Diff \| Diff
Another patch for landing. (92.93 KB, patch) 2015-11-09 18:17 PST, Eric Carlson	commit-queue: commit-queue-	Details \| Formatted Diff \| Diff
One more time? (89.49 KB, patch) 2015-11-09 21:26 PST, Eric Carlson	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (10) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Eric Carlson 2015-09-06 12:27:20 PDT

Add a mock AppleTV device to make testing possible.

Comment 1 Radar WebKit Bug Importer 2015-09-06 12:31:46 PDT

<rdar://problem/22596272>

Comment 2 Eric Carlson 2015-09-06 13:10:50 PDT

Created attachment 260713 [details]
Proposed patch.

Comment 3 WebKit Commit Bot 2015-09-06 13:13:02 PDT

Attachment 260713 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/MediaPlaybackTargetPicker.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:2866:  Missing space before {  [whitespace/braces] [5]
Total errors found: 3 in 49 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 4 Build Bot 2015-09-06 13:56:25 PDT

Comment on attachment 260713 [details]
Proposed patch.

Attachment 260713 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/146305

New failing tests:
media/controls/airplay-picker.html

Comment 5 Build Bot 2015-09-06 13:56:27 PDT

Created attachment 260716 [details]
Archive of layout-test-results from ews106 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

Comment 6 Build Bot 2015-09-06 14:11:42 PDT

Comment on attachment 260713 [details]
Proposed patch.

Attachment 260713 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/146327

New failing tests:
media/controls/airplay-picker.html

Comment 7 Build Bot 2015-09-06 14:11:45 PDT

Created attachment 260717 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

Comment 8 Eric Carlson 2015-09-06 15:19:25 PDT

Created attachment 260719 [details]
Updated patch.

Comment 9 Eric Carlson 2015-09-06 16:17:55 PDT

Created attachment 260721 [details]
Updated patch.

Comment 10 Eric Carlson 2015-09-06 16:54:14 PDT

Created attachment 260726 [details]
YAUP.

Comment 11 Jer Noble 2015-09-08 14:51:09 PDT

Comment on attachment 260726 [details]
YAUP.

Unofficial r+, but needs a WK2 owner to do a final sign-off.

Comment 12 Tim Horton 2015-09-10 11:09:29 PDT

Comment on attachment 260726 [details]
YAUP.

View in context: https://bugs.webkit.org/attachment.cgi?id=260726&action=review

r+ the WK2 parts, with Jer's r+ for the other bits.

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:2211
> +        return decodePlatformData(decoder, target);

There's this funny thing where if there's ever a path through a decoder that doesn't write to a field, you can end up with stale data if you re-decode into the same target (which happens on occasion). Please consider clearing the platform data if we're not writing to it, and the others if we're not writing to them.

Comment 13 Alexey Proskuryakov 2015-09-17 14:15:30 PDT

Please unskip media/controls/airplay-picker.html when this is done.

Comment 14 Eric Carlson 2015-11-09 12:43:39 PST

Created attachment 265082 [details]
Patch for landing.

Comment 15 WebKit Commit Bot 2015-11-09 13:32:30 PST

Comment on attachment 265082 [details]
Patch for landing.

Rejecting attachment 265082 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 265082, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 192172 = 7110aaa00b572a4843a3b6327bba8ed9f46da4af
r192173 = 3943995b1795d43bb008f0164ea176c68c977fbc
r192174 = c4b8e58fb6cf85eaeeeab58749f7a3b5a68849c2
r192175 = 1d8f06915dd20f4bda15034462350931d75ed264
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/407024

Comment 16 Eric Carlson 2015-11-09 16:37:44 PST

Created attachment 265117 [details]
Updated patch for landing.

Comment 17 WebKit Commit Bot 2015-11-09 16:39:46 PST

Comment on attachment 265117 [details]
Updated patch for landing.

Rejecting attachment 265117 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 265117, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 3.
patching file LayoutTests/media/controls/airplay-picker-expected.txt
patching file LayoutTests/media/controls/airplay-picker.html
patching file LayoutTests/media/controls/controls-test-helpers.js
patching file LayoutTests/platform/mac/TestExpectations
Hunk #1 FAILED at 1363.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/mac/TestExpectations.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/407599

Comment 18 Eric Carlson 2015-11-09 18:00:03 PST

Created attachment 265133 [details]
One more time?

Comment 19 WebKit Commit Bot 2015-11-09 18:02:46 PST

Comment on attachment 265133 [details]
One more time?

Rejecting attachment 265133 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 265133, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
g file Source/WebKit/mac/WebView/WebViewInternal.h
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/media/controls/airplay-picker-expected.txt
patching file LayoutTests/media/controls/airplay-picker.html
patching file LayoutTests/media/controls/controls-test-helpers.js
patching file LayoutTests/platform/mac/TestExpectations

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/407939

Comment 20 Eric Carlson 2015-11-09 18:07:27 PST

Created attachment 265134 [details]
Another patch for landing.

Comment 21 WebKit Commit Bot 2015-11-09 18:09:47 PST

Comment on attachment 265134 [details]
Another patch for landing.

Rejecting attachment 265134 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 265134, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
g file Source/WebKit/mac/WebView/WebViewInternal.h
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/media/controls/airplay-picker-expected.txt
patching file LayoutTests/media/controls/airplay-picker.html
patching file LayoutTests/media/controls/controls-test-helpers.js
patching file LayoutTests/platform/mac/TestExpectations

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/407988

Comment 22 Eric Carlson 2015-11-09 18:17:04 PST

Created attachment 265136 [details]
Another patch for landing.

Comment 23 WebKit Commit Bot 2015-11-09 18:19:41 PST

Comment on attachment 265136 [details]
Another patch for landing.

Rejecting attachment 265136 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 265136, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
g file Source/WebKit/mac/WebView/WebViewInternal.h
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/media/controls/airplay-picker-expected.txt
patching file LayoutTests/media/controls/airplay-picker.html
patching file LayoutTests/media/controls/controls-test-helpers.js
patching file LayoutTests/platform/mac/TestExpectations

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/408048

Comment 24 Eric Carlson 2015-11-09 21:26:31 PST

Created attachment 265142 [details]
One more time?

Comment 25 WebKit Commit Bot 2015-11-09 22:25:56 PST

Comment on attachment 265142 [details]
One more time?

Clearing flags on attachment: 265142

Committed r192200: <http://trac.webkit.org/changeset/192200>

Comment 26 Csaba Osztrogonác 2015-11-10 03:57:11 PST

(In reply to comment #25)
> Comment on attachment 265142 [details]
> One more time?
> 
> Clearing flags on attachment: 265142
> 
> Committed r192200: <http://trac.webkit.org/changeset/192200>

It broke the build on Apple El Capitan bots:
https://build.webkit.org/waterfall

Comment 27 Csaba Osztrogonác 2015-11-10 04:06:19 PST

fixed in http://trac.webkit.org/changeset/192230

Comment 28 Eric Carlson 2015-11-10 05:57:01 PST

(In reply to comment #27)
> fixed in http://trac.webkit.org/changeset/192230

Thank you Ossy!