Bug 148750 - Web Inspector: should crash on purpose if InjectedScriptSource.js is unparseable
Summary: Web Inspector: should crash on purpose if InjectedScriptSource.js is unparseable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: BJ Burg
URL:
Keywords: InRadar
Depends on:
Blocks: InspectorDebug
  Show dependency tree / graph
 
Reported: 2015-09-03 14:19 PDT by BJ Burg
Modified: 2020-04-30 10:20 PDT (History)
8 users (show)

See Also:

Attachments
Proposed Fix (2.04 KB, patch)
2015-09-03 14:27 PDT, BJ Burg 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description BJ Burg 2015-09-03 14:19:13 PDT 
If the injected script cannot be parsed as a ScriptObject, the current behavior is to crash some time later.
This patch adds a release assertion after trying to inject the script, and dumps the injected script source text that was embedded into the binary.
Comment 1 BJ Burg 2015-09-03 14:27:54 PDT 
Created attachment 260523 [details]
Proposed Fix
Comment 2 WebKit Commit Bot 2015-09-03 15:29:01 PDT 
Comment on attachment 260523 [details]
Proposed Fix

Clearing flags on attachment: 260523

Committed r189295: <http://trac.webkit.org/changeset/189295>
Comment 3 WebKit Commit Bot 2015-09-03 15:29:05 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2015-09-03 17:48:25 PDT 
<rdar://problem/22569879>