Once RepatchBuffer is stateless, it won't make any sense to instantiate it or pass it around.
Created attachment 260516 [details] it's a start
Created attachment 260518 [details] getting close
Created attachment 260519 [details] the patch
Comment on attachment 260519 [details] the patch r=me
Attachment 260519 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/jit/JIT.h:183: The parameter name "returnAddress" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 1 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 260519 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=260519&action=review r=me > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:-2003 > - <ClInclude Include="..\assembler\RepatchBuffer.h"> > - <Filter>assembler</Filter> > - </ClInclude> You also need to remove this from Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj
(In reply to comment #6) > Comment on attachment 260519 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=260519&action=review > > r=me > > > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:-2003 > > - <ClInclude Include="..\assembler\RepatchBuffer.h"> > > - <Filter>assembler</Filter> > > - </ClInclude> > > You also need to remove this from > Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCore.vcxproj Fixed, along with 32-bit builds.
Landed in http://trac.webkit.org/changeset/189288