Bug 148741 - RepatchBuffer should be stateless
Summary: RepatchBuffer should be stateless
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
Depends on:
Blocks: 148742
  Show dependency treegraph
Reported: 2015-09-03 11:15 PDT by Filip Pizlo
Modified: 2015-09-03 12:42 PDT (History)
11 users (show)

See Also:

the patch (34.81 KB, patch)
2015-09-03 11:24 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
more fixes (34.92 KB, patch)
2015-09-03 11:29 PDT, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2015-09-03 11:15:16 PDT
We use the CodeBlock* field of RepatchBuffer in various places.  Usually, when we use this field, we're doing it wrong, since we never really know which CodeBlock* the RepatchBuffer points to.

Also, this field was there to support WX_EXCLUSIVE, which doesn't work anymore and probably never will (since nobody is working on it).  Killing that feature means that we no longer have to be careful about caching a RepatchBuffer and passing it around.
Comment 1 Filip Pizlo 2015-09-03 11:24:43 PDT
Created attachment 260498 [details]
the patch
Comment 2 Filip Pizlo 2015-09-03 11:29:12 PDT
Created attachment 260500 [details]
more fixes
Comment 3 Geoffrey Garen 2015-09-03 11:30:32 PDT
Comment on attachment 260500 [details]
more fixes

Comment 4 Filip Pizlo 2015-09-03 12:42:12 PDT
Landed in http://trac.webkit.org/changeset/189278