WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
148704
Reset the status label when the media is playable
https://bugs.webkit.org/show_bug.cgi?id=148704
Summary
Reset the status label when the media is playable
Alexey Proskuryakov
Reported
2015-09-01 22:30:13 PDT
The new test media/controls/statusDisplay.html is flaky, at least on Mavericks:
https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fcontrols%2FstatusDisplay.html
@@ -6,6 +6,6 @@ EVENT(canplaythrough) EXPECTED (statusDisplayInfo.name == 'Status Display') OK EXPECTED (statusDisplayInfo.className == 'hidden') OK -EXPECTED (statusDisplayInfo.content == '') OK +EXPECTED (statusDisplayInfo.content == ''), OBSERVED 'Loading' FAIL
Attachments
Patch
(1.93 KB, patch)
2015-09-02 13:08 PDT
,
Dean Jackson
eric.carlson
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dean Jackson
Comment 1
2015-09-02 11:16:15 PDT
Hmmm... this might be an actual bug caught by the new test. Maybe the status label isn't getting reset?
Radar WebKit Bug Importer
Comment 2
2015-09-02 11:17:48 PDT
<
rdar://problem/22541939
>
Dean Jackson
Comment 3
2015-09-02 13:08:36 PDT
Created
attachment 260430
[details]
Patch
Alexey Proskuryakov
Comment 4
2015-09-02 19:43:09 PDT
Comment on
attachment 260430
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=260430&action=review
> Source/WebCore/ChangeLog:9 > + Flakiness on the bots uncovered a situation where we
Yay!
Alexey Proskuryakov
Comment 5
2015-09-03 19:40:19 PDT
Dean committed the fix in <
http://trac.webkit.org/changeset/189262
>, and I can confirm that the test isn't flaky any more.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug