Bug 148704 - Reset the status label when the media is playable
Summary: Reset the status label when the media is playable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-09-01 22:30 PDT by Alexey Proskuryakov
Modified: 2015-09-03 19:40 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.93 KB, patch)
2015-09-02 13:08 PDT, Dean Jackson 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2015-09-01 22:30:13 PDT 
The new test media/controls/statusDisplay.html is flaky, at least on Mavericks:

https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fcontrols%2FstatusDisplay.html

@@ -6,6 +6,6 @@
 EVENT(canplaythrough)
 EXPECTED (statusDisplayInfo.name == 'Status Display') OK
 EXPECTED (statusDisplayInfo.className == 'hidden') OK
-EXPECTED (statusDisplayInfo.content == '') OK
+EXPECTED (statusDisplayInfo.content == ''), OBSERVED 'Loading' FAIL
Comment 1 Dean Jackson 2015-09-02 11:16:15 PDT 
Hmmm... this might be an actual bug caught by the new test.

Maybe the status label isn't getting reset?
Comment 2 Radar WebKit Bug Importer 2015-09-02 11:17:48 PDT 
<rdar://problem/22541939>
Comment 3 Dean Jackson 2015-09-02 13:08:36 PDT 
Created attachment 260430 [details]
Patch
Comment 4 Alexey Proskuryakov 2015-09-02 19:43:09 PDT 
Comment on attachment 260430 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260430&action=review

> Source/WebCore/ChangeLog:9
> +        Flakiness on the bots uncovered a situation where we

Yay!
Comment 5 Alexey Proskuryakov 2015-09-03 19:40:19 PDT 
Dean committed the fix in <http://trac.webkit.org/changeset/189262>, and I can confirm that the test isn't flaky any more.