Bug 148656 - [mediacontrols] Add tests for the status display label
Summary: [mediacontrols] Add tests for the status display label
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-31 16:50 PDT by Dean Jackson
Modified: 2015-09-01 22:30 PDT (History)
1 user (show)

See Also:

Attachments
Patch (7.92 KB, patch)
2015-08-31 16:56 PDT, Dean Jackson 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2015-08-31 16:50:38 PDT 
[mediacontrols] Add tests for the status display label
Comment 1 Radar WebKit Bug Importer 2015-08-31 16:51:44 PDT 
<rdar://problem/22509779>
Comment 2 Dean Jackson 2015-08-31 16:56:03 PDT 
Created attachment 260330 [details]
Patch
Comment 3 Eric Carlson 2015-08-31 18:25:11 PDT 
Comment on attachment 260330 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=260330&action=review

> LayoutTests/ChangeLog:15
> +        * media/controls/statusDisplay-expected.txt: Added.
> +        * media/controls/statusDisplay.html: Added.
> +        * media/controls/statusDisplayBad-expected.txt: Added.
> +        * media/controls/statusDisplayBad.html: Added.

Shouldn't these be skipped on non-Apple ports?

> LayoutTests/media/controls/statusDisplay.html:28
> +                    showControlsButtonInfo = currentStatus

Nit: this isn't used.

> LayoutTests/media/controls/statusDisplayBad.html:27
> +                    showControlsButtonInfo = currentStatus

Ditto.
Comment 4 Dean Jackson 2015-09-01 10:39:38 PDT 
Committed r189215: <http://trac.webkit.org/changeset/189215>
Comment 5 Alexey Proskuryakov 2015-09-01 22:30:57 PDT 
A test added here is flaky, please see bug 148704.