RESOLVED FIXED 148656
[mediacontrols] Add tests for the status display label 
https://bugs.webkit.org/show_bug.cgi?id=148656
Summary [mediacontrols] Add tests for the status display label
Dean Jackson
Reported 2015-08-31 16:50:38 PDT
[mediacontrols] Add tests for the status display label
Attachments
Patch (7.92 KB, patch)
2015-08-31 16:56 PDT, Dean Jackson 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2015-08-31 16:51:44 PDT
<rdar://problem/22509779>
Dean Jackson
Comment 2 2015-08-31 16:56:03 PDT
Created attachment 260330 [details] Patch
Eric Carlson
Comment 3 2015-08-31 18:25:11 PDT
Comment on attachment 260330 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=260330&action=review > LayoutTests/ChangeLog:15 > + * media/controls/statusDisplay-expected.txt: Added. > + * media/controls/statusDisplay.html: Added. > + * media/controls/statusDisplayBad-expected.txt: Added. > + * media/controls/statusDisplayBad.html: Added. Shouldn't these be skipped on non-Apple ports? > LayoutTests/media/controls/statusDisplay.html:28 > + showControlsButtonInfo = currentStatus Nit: this isn't used. > LayoutTests/media/controls/statusDisplayBad.html:27 > + showControlsButtonInfo = currentStatus Ditto.
Dean Jackson
Comment 4 2015-09-01 10:39:38 PDT
Committed r189215: <http://trac.webkit.org/changeset/189215>
Alexey Proskuryakov
Comment 5 2015-09-01 22:30:57 PDT
A test added here is flaky, please see bug 148704.
Note You need to log in before you can comment on or make changes to this bug.