Bug 148702 - [GStreamer] Simplify linking pads in AudioDestination and correct old comment.
Summary: [GStreamer] Simplify linking pads in AudioDestination and correct old comment.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-01 21:15 PDT by Hyemi Shin
Modified: 2015-09-02 10:39 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.98 KB, patch)
2015-09-01 22:51 PDT, Hyemi Shin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hyemi Shin 2015-09-01 21:15:25 PDT
After https://bugs.webkit.org/show_bug.cgi?id=139370 applied, many lines had been changed but one comment wasn't changed along implementation.
And linking src pad of webkitAudioSrc could be simplified because whole elements are linked in one function.
Comment 1 Hyemi Shin 2015-09-01 21:32:04 PDT
I'm in trouble with uploading my patch behind proxy..
Comment 2 Hyemi Shin 2015-09-01 22:51:52 PDT
Created attachment 260412 [details]
Patch
Comment 3 WebKit Commit Bot 2015-09-02 02:42:29 PDT
Comment on attachment 260412 [details]
Patch

Rejecting attachment 260412 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 260412, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Password for 'commit-queue@webkit.org': 
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Username: error: git-svn died of signal 11

Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/132523
Comment 4 Philippe Normand 2015-09-02 03:19:40 PDT
Comment on attachment 260412 [details]
Patch

Let's try again...
Comment 5 WebKit Commit Bot 2015-09-02 04:05:41 PDT
Comment on attachment 260412 [details]
Patch

Rejecting attachment 260412 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 260412, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit

Committing to http://svn.webkit.org/repository/webkit/trunk ...
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Password for 'commit-queue@webkit.org': 
Authentication realm: <http://svn.webkit.org:80> Mac OS Forge
Username: error: git-svn died of signal 11

Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 139 cwd: /Volumes/Data/EWS/WebKit
Updating OpenSource
Current branch master is up to date.

Full output: http://webkit-queues.webkit.org/results/132706
Comment 6 WebKit Commit Bot 2015-09-02 06:18:22 PDT
Comment on attachment 260412 [details]
Patch

Rejecting attachment 260412 [details] from commit-queue.

hyemi.sin@samsung.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 7 WebKit Commit Bot 2015-09-02 10:39:19 PDT
Comment on attachment 260412 [details]
Patch

Clearing flags on attachment: 260412

Committed r189255: <http://trac.webkit.org/changeset/189255>
Comment 8 WebKit Commit Bot 2015-09-02 10:39:23 PDT
All reviewed patches have been landed.  Closing bug.