[GStreamer] Major cleanups of AudioDestination implementation

[Sebastian Dröge (slomo)]

Patch coming in a second.

[Sebastian Dröge (slomo)]

Created attachment 242753 [details]
Patch

[WebKit Commit Bot]

Attachment 242753 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:83:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sebastian Dröge (slomo)]

This style error was there before, what do you suggest for fixing this? It's not clear to me what the style guide recommends for cases like this.

[Sebastian Dröge (slomo)]

Created attachment 242756 [details]
Patch

[Sebastian Dröge (slomo)]

Created attachment 242763 [details]
Patch

[Sebastian Dröge (slomo)]

Created attachment 242767 [details]
Patch

[Philippe Normand]

Comment on attachment 242763 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242763&action=review

> Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:66
> +    guint64 numSamples;

We usually try to avoid abbreviations in variable names. I don't have many suggestions, I'm bad at naming stuff :)

[Sebastian Dröge (slomo)]

I could call it numberOfSamples if you prefer that :) Should I change it or is it ok like that?

[Sebastian Dröge (slomo)]

Created attachment 242789 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 242789 [details]
Patch

Clearing flags on attachment: 242789

Committed r176943: <http://trac.webkit.org/changeset/176943>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.