WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
148698
Web Inspector: Move PrettyPrinting tests into LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=148698
Summary
Web Inspector: Move PrettyPrinting tests into LayoutTests
Joseph Pecoraro
Reported
2015-09-01 17:56:37 PDT
* SUMMARY Move PrettyPrinting tests into LayoutTests.
Attachments
[PATCH] Proposed Fix
(54.06 KB, patch)
2015-09-01 18:01 PDT
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2015-09-01 17:57:05 PDT
<
rdar://problem/22531096
>
Joseph Pecoraro
Comment 2
2015-09-01 18:01:53 PDT
Created
attachment 260398
[details]
[PATCH] Proposed Fix Tests can still be run from WebInspectorUI/Tools/PrettyPrinting but they are now automatically run with LayoutTests/inspector tests.
WebKit Commit Bot
Comment 3
2015-09-01 18:56:12 PDT
Comment on
attachment 260398
[details]
[PATCH] Proposed Fix Clearing flags on attachment: 260398 Committed
r189241
: <
http://trac.webkit.org/changeset/189241
>
WebKit Commit Bot
Comment 4
2015-09-01 18:56:14 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5
2015-09-01 22:04:43 PDT
These tests crash in debug, and sometimes fail in release:
https://build.webkit.org/results/Apple%20Yosemite%20Debug%20WK1%20(Tests)/r189243%20(7198)/results.html
https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK2%20(Tests)/r189243%20(7994)/results.html
Will roll out.
WebKit Commit Bot
Comment 6
2015-09-01 22:06:57 PDT
Re-opened since this is blocked by
bug 148703
Joseph Pecoraro
Comment 7
2015-09-02 16:00:31 PDT
Blocked by
bug 148727
, which should fix this ASSERT for us.
Joseph Pecoraro
Comment 8
2015-09-08 11:48:30 PDT
Remanded in:
https://trac.webkit.org/r189500
Joseph Pecoraro
Comment 9
2015-09-08 13:50:56 PDT
Follow-up after Test.js magnification:
http://trac.webkit.org/changeset/189505
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug