Bug 148698 - Web Inspector: Move PrettyPrinting tests into LayoutTests
Summary: Web Inspector: Move PrettyPrinting tests into LayoutTests
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
Keywords: InRadar
Depends on: 148703
  Show dependency treegraph
Reported: 2015-09-01 17:56 PDT by Joseph Pecoraro
Modified: 2015-09-08 13:50 PDT (History)
8 users (show)

See Also:

[PATCH] Proposed Fix (54.06 KB, patch)
2015-09-01 18:01 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2015-09-01 17:56:37 PDT
Move PrettyPrinting tests into LayoutTests.
Comment 1 Radar WebKit Bug Importer 2015-09-01 17:57:05 PDT
Comment 2 Joseph Pecoraro 2015-09-01 18:01:53 PDT
Created attachment 260398 [details]
[PATCH] Proposed Fix

Tests can still be run from WebInspectorUI/Tools/PrettyPrinting but they are now automatically run with LayoutTests/inspector tests.
Comment 3 WebKit Commit Bot 2015-09-01 18:56:12 PDT
Comment on attachment 260398 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 260398

Committed r189241: <http://trac.webkit.org/changeset/189241>
Comment 4 WebKit Commit Bot 2015-09-01 18:56:14 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Commit Bot 2015-09-01 22:06:57 PDT
Re-opened since this is blocked by bug 148703
Comment 7 Joseph Pecoraro 2015-09-02 16:00:31 PDT
Blocked by bug 148727, which should fix this ASSERT for us.
Comment 8 Joseph Pecoraro 2015-09-08 11:48:30 PDT
Remanded in: https://trac.webkit.org/r189500
Comment 9 Joseph Pecoraro 2015-09-08 13:50:56 PDT
Follow-up after Test.js magnification: