Bug 148727 – Add a new ResourceLoaderOption to avoid page defers loading mechanisms for inspector

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Add a new ResourceLoaderOption to avoid page defers loading mechanisms for inspector.

Web Inspector has the capability to load arbitrary URLs through the inspected page (Network.loadResource). This capability is used for loading SourceMap resources through the inspected page. We also want to use this in tests, to load test resources through the inspected page.

In WebCore, defers loading is a Page attribute. When the Page's defersLoading state changes it cascades to all ResourceHandles tied to that page (cascading through FrameResourceLoader, DocumentLoader, SubresourceLoader, ResourceLoader, ResourceHandle). However, this Web Inspector resource load doesn't want to respect the Page's defersLoading status. For instance, if the page is Paused it will be deferring network loads, but we still want this inspector resource load to finish.

InspectorResourceAgent right now, always attempts to disable the defers loading state of the loader. This will ASSERT in ResourceHandle if the value didn't change, which is a useful ASSERT to detect accidental imbalances. As such, no manipulation of this flag apart from matching the Page would be perfect.

A better approach, would be to disallow defers loading entirely for this loader. We can add a ResourceLoaderOption to this extent, and just never allow it to be deferred.

[Joseph Pecoraro]

Created attachment 260448 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 260466 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 260466 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 260466

Committed r189432: <http://trac.webkit.org/changeset/189432>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.