RESOLVED FIXED 148627
[WinCairo] Fix the WinCairo build after landing of webkit.org/b/148561 
https://bugs.webkit.org/show_bug.cgi?id=148627
Summary [WinCairo] Fix the WinCairo build after landing of webkit.org/b/148561
Sungmann Cho
Reported 2015-08-30 19:22:21 PDT
SSIA
Attachments
Patch (1.83 KB, patch)
2015-08-30 19:23 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
Patch (4.84 KB, patch)
2015-08-30 19:42 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
Patch (4.99 KB, patch)
2015-08-30 19:49 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sungmann Cho
Comment 1 2015-08-30 19:23:44 PDT
Created attachment 260265 [details] Patch
Sungmann Cho
Comment 2 2015-08-30 19:29:02 PDT
Currently, ToT breaks at: ..\platform\graphics\win\ImageCairoWin.cpp(84): error C2664: 'void WebCore::BitmapImage::draw(WebCore::GraphicsContext &,const WebCore::FloatRect &,const WebCore::FloatRect &,WebCore::ColorSpace,WebCore::CompositeOperator,WebCore::BlendMode,WebCore::ImageOrientationDescription)': cannot convert argument 1 from 'WebCore::GraphicsContext *' to 'WebCore::GraphicsContext &'
Sungmann Cho
Comment 3 2015-08-30 19:42:32 PDT
Created attachment 260266 [details] Patch
Sungmann Cho
Comment 4 2015-08-30 19:49:11 PDT
Created attachment 260268 [details] Patch
Sungmann Cho
Comment 5 2015-08-30 19:49:49 PDT
Currently, ToT breaks at: 18>..\platform\graphics\win\ImageCairoWin.cpp(84): error C2664: 'void WebCore::BitmapImage::draw(WebCore::GraphicsContext &,const WebCore::FloatRect &,const WebCore::FloatRect &,WebCore::ColorSpace,WebCore::CompositeOperator,WebCore::BlendMode,WebCore::ImageOrientationDescription)': cannot convert argument 1 from 'WebCore::GraphicsContext *' to 'WebCore::GraphicsContext &' 18>C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\memory(1636): error C2259: 'WebCore::MediaPlayerPrivateMediaFoundation': cannot instantiate abstract class (compiling source file ..\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp) 18> C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\memory(1636): note: due to following members: (compiling source file ..\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp) 18> C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\memory(1636): note: 'void WebCore::MediaPlayerPrivateInterface::paint(WebCore::GraphicsContext &,const WebCore::FloatRect &)': is abstract (compiling source file ..\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp) 18> D:\FOSS\WebKit\Source\WebCore\platform\graphics\MediaPlayerPrivate.h(147): note: see declaration of 'WebCore::MediaPlayerPrivateInterface::paint' (compiling source file ..\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp) 18> ..\platform\graphics\win\MediaPlayerPrivateMediaFoundation.cpp(81): note: see reference to function template instantiation 'std::unique_ptr<WebCore::MediaPlayerPrivateMediaFoundation,std::default_delete<WebCore::MediaPlayerPrivateMediaFoundation>> std::make_unique<WebCore::MediaPlayerPrivateMediaFoundation,WebCore::MediaPlayer*&>(WebCore::MediaPlayer *&)' being compiled
WebKit Commit Bot
Comment 6 2015-08-31 01:51:29 PDT
Comment on attachment 260268 [details] Patch Clearing flags on attachment: 260268 Committed r189165: <http://trac.webkit.org/changeset/189165>
WebKit Commit Bot
Comment 7 2015-08-31 01:51:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.