Bug 148561 - Migrate GraphicsContexts from pointers to references
Summary: Migrate GraphicsContexts from pointers to references
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
: 148558 148590 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-08-27 22:14 PDT by Myles C. Maxfield
Modified: 2015-08-28 23:50 PDT (History)
2 users (show)

See Also:

Attachments
Patch (50.52 KB, patch)
2015-08-27 22:45 PDT, Myles C. Maxfield 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-mavericks (886.58 KB, application/zip)
2015-08-27 23:23 PDT, Build Bot 		no flags Details
Archive of layout-test-results from ews104 for mac-mavericks-wk2 (949.43 KB, application/zip)
2015-08-27 23:27 PDT, Build Bot 		no flags Details
Patch (689.66 KB, patch)
2015-08-28 19:33 PDT, Myles C. Maxfield 		thorton: review+
Details | Formatted Diff | Diff
Patch (698.01 KB, patch)
2015-08-28 20:58 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (709.74 KB, patch)
2015-08-28 21:21 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (710.45 KB, patch)
2015-08-28 21:29 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (712.29 KB, patch)
2015-08-28 21:46 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (716.67 KB, patch)
2015-08-28 22:09 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (719.24 KB, patch)
2015-08-28 22:39 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (721.51 KB, patch)
2015-08-28 22:56 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (9) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-08-27 22:14:51 PDT 
Migrate from pointers to references for text drawing code
Comment 1 Myles C. Maxfield 2015-08-27 22:45:25 PDT 
Created attachment 260125 [details]
Patch
Comment 2 Build Bot 2015-08-27 23:23:06 PDT 
Comment on attachment 260125 [details]
Patch

Attachment 260125 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/115456

New failing tests:
imported/mozilla/svg/text/simple-fill-gradient.svg
imported/mozilla/svg/text-layout-06.svg
svg/custom/hidpi-masking-clipping.svg
imported/mozilla/svg/text-scale-02.svg
Comment 3 Build Bot 2015-08-27 23:23:09 PDT 
Created attachment 260128 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5
Comment 4 Build Bot 2015-08-27 23:27:16 PDT 
Comment on attachment 260125 [details]
Patch

Attachment 260125 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/115460

New failing tests:
imported/mozilla/svg/text/simple-fill-gradient.svg
imported/mozilla/svg/text-layout-06.svg
svg/custom/hidpi-masking-clipping.svg
imported/mozilla/svg/text-scale-02.svg
Comment 5 Build Bot 2015-08-27 23:27:19 PDT 
Created attachment 260129 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5
Comment 6 Myles C. Maxfield 2015-08-28 18:52:08 PDT 
*** Bug 148590 has been marked as a duplicate of this bug. ***
Comment 7 Myles C. Maxfield 2015-08-28 18:55:17 PDT 
*** Bug 148558 has been marked as a duplicate of this bug. ***
Comment 8 Myles C. Maxfield 2015-08-28 19:33:27 PDT 
Created attachment 260203 [details]
Patch
Comment 9 Tim Horton 2015-08-28 19:38:10 PDT 
Comment on attachment 260203 [details]
Patch

rs=me. sad that the storage on PaintInfo can't be a reference (and then you wouldn't need the getter). maybe in the future?
Comment 10 Myles C. Maxfield 2015-08-28 20:58:20 PDT 
Created attachment 260208 [details]
Patch
Comment 11 Myles C. Maxfield 2015-08-28 21:21:56 PDT 
Created attachment 260209 [details]
Patch
Comment 12 Myles C. Maxfield 2015-08-28 21:29:39 PDT 
Created attachment 260211 [details]
Patch
Comment 13 Myles C. Maxfield 2015-08-28 21:46:11 PDT 
Created attachment 260213 [details]
Patch
Comment 14 Myles C. Maxfield 2015-08-28 22:09:01 PDT 
Created attachment 260216 [details]
Patch
Comment 15 Myles C. Maxfield 2015-08-28 22:39:11 PDT 
Created attachment 260217 [details]
Patch
Comment 16 Myles C. Maxfield 2015-08-28 22:56:39 PDT 
Created attachment 260218 [details]
Patch
Comment 17 Myles C. Maxfield 2015-08-28 23:15:53 PDT 
Committed r189144: <http://trac.webkit.org/changeset/189144>
Comment 18 Myles C. Maxfield 2015-08-28 23:33:09 PDT 
Committed r189145: <http://trac.webkit.org/changeset/189145>
Comment 19 Myles C. Maxfield 2015-08-28 23:50:06 PDT 
Committed r189147: <http://trac.webkit.org/changeset/189147>