Bug 148458 - AX: Enable accessibility/aria-controls.html test for mac
Summary: AX: Enable accessibility/aria-controls.html test for mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-08-25 18:26 PDT by Nan Wang
Modified: 2015-08-25 23:50 PDT (History)
11 users (show)

See Also:

Attachments
patch (7.41 KB, patch)
2015-08-25 18:31 PDT, Nan Wang 		no flags Details | Formatted Diff | Diff
patch (7.47 KB, patch)
2015-08-25 22:23 PDT, Nan Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nan Wang 2015-08-25 18:26:03 PDT 
The test is marked Skip in TestExpectation file.
Comment 1 Nan Wang 2015-08-25 18:31:41 PDT 
Created attachment 259910 [details]
patch
Comment 2 chris fleizach 2015-08-25 20:32:32 PDT 
How come you're not using the string value in the test like the other platform
That looks like a good check because it's able to validate that the element at that index is actually the right one
Comment 3 Nan Wang 2015-08-25 21:02:49 PDT 
(In reply to comment #2)
> How come you're not using the string value in the test like the other
> platform
> That looks like a good check because it's able to validate that the element
> at that index is actually the right one

On Mac, the string value for the div is empty. Should I change the element type?
Comment 4 chris fleizach 2015-08-25 22:01:38 PDT 
That's probably because a div is being returned 
On Mac platform we should get the child of that object and check the string value I think
Comment 5 Nan Wang 2015-08-25 22:23:44 PDT 
Created attachment 259926 [details]
patch
Comment 6 WebKit Commit Bot 2015-08-25 23:50:01 PDT 
Comment on attachment 259926 [details]
patch

Clearing flags on attachment: 259926

Committed r188947: <http://trac.webkit.org/changeset/188947>
Comment 7 WebKit Commit Bot 2015-08-25 23:50:05 PDT 
All reviewed patches have been landed.  Closing bug.