Bug 127908 - [ATK] Expose aria-controls through ATK_RELATION_CONTROLLER_FOR
Summary: [ATK] Expose aria-controls through ATK_RELATION_CONTROLLER_FOR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-01-30 06:19 PST by Krzysztof Czech
Modified: 2014-02-03 01:12 PST (History)
10 users (show)

See Also:

Attachments
patch (20.93 KB, patch)
2014-01-30 06:46 PST, Krzysztof Czech 		mario: review-
Details | Formatted Diff | Diff
patch (22.98 KB, patch)
2014-01-31 02:20 PST, Krzysztof Czech 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Krzysztof Czech 2014-01-30 06:19:33 PST 
Based on what w3c says, aria-controls could be exposed through ATK_RELATION_CONTROLLER_FOR.
Comment 1 Radar WebKit Bug Importer 2014-01-30 06:20:00 PST 
<rdar://problem/15945816>
Comment 2 Krzysztof Czech 2014-01-30 06:46:02 PST 
Created attachment 222666 [details]
patch
Comment 3 Mario Sanchez Prada 2014-01-30 07:24:36 PST 
Comment on attachment 222666 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222666&action=review

The patch looks good to me, but you need to add empty stubs for Mac and iOS too. More specifically, the missing stubs would go to:

  Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
  Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
  Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1027
> +

Extra line
Comment 4 Krzysztof Czech 2014-01-30 07:31:14 PST 
> The patch looks good to me, but you need to add empty stubs for Mac and iOS too. More specifically, the missing stubs would go to:
> 
>   Tools/DumpRenderTree/ios/AccessibilityUIElementIOS.mm
>   Tools/DumpRenderTree/mac/AccessibilityUIElementMac.mm
>   Tools/WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm
> 
> > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1027
> > +
> 
> Extra line

Ops, right I forgot, thanks.
Comment 5 Krzysztof Czech 2014-01-31 02:20:13 PST 
Created attachment 222806 [details]
patch
Comment 6 WebKit Commit Bot 2014-02-03 01:12:07 PST 
Comment on attachment 222806 [details]
patch

Clearing flags on attachment: 222806

Committed r163296: <http://trac.webkit.org/changeset/163296>
Comment 7 WebKit Commit Bot 2014-02-03 01:12:11 PST 
All reviewed patches have been landed.  Closing bug.