Bug 148282 – [EFL] Revise PlatformWebView ctor according to r188718

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Joonghun Park]

https://bugs.webkit.org/show_bug.cgi?id=147996 changed PlatformWebView ctor's argument to use WKPageConfigurationRef instead of WKContextRef and WKPageGroupRef respectively.
So change the ctor argument aligning with it.

[Joonghun Park]

Created attachment 259565 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 259565 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259565&action=review

> Source/WebKit2/PlatformEfl.cmake:68
> +    UIProcess/API/C/WKPageConfigurationRef.cpp

Wrong alphabet order.

[Gyuyoung Kim]

Committed r188751: <http://trac.webkit.org/changeset/188751>

[Gyuyoung Kim]

(In reply to comment #3)
> Committed r188751: <http://trac.webkit.org/changeset/188751>

Land after fixing it.

[Joonghun Park]

(In reply to comment #2)
> Comment on attachment 259565 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=259565&action=review
> 
> > Source/WebKit2/PlatformEfl.cmake:68
> > +    UIProcess/API/C/WKPageConfigurationRef.cpp
> 
> Wrong alphabet order.

If I place files as below,

UIProcess/API/C/CoordinatedGraphics/WKView.cpp
UIProcess/API/C/WKPageConfigurationRef.cpp

then when I run check-webkit-style script, I meet the log like this.

Source/WebKit2/PlatformEfl.cmake:69:  Alphabetical sorting problem. "UIProcess/API/C/WKPageConfigurationRef.cpp" should be before "UIProcess/API/C/CoordinatedGraphics/WKView.cpp".

It seems that WKPageConfigurationRef.cpp is precede to WKView.cpp 
because the former is file name and the latter is an intermediate path name I think.

So I guess the current alphabetical order is the right one.

[Gyuyoung Kim]

(In reply to comment #5)
> (In reply to comment #2)
> > Comment on attachment 259565 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=259565&action=review
> > 
> > > Source/WebKit2/PlatformEfl.cmake:68
> > > +    UIProcess/API/C/WKPageConfigurationRef.cpp
> > 
> > Wrong alphabet order.
> 
> If I place files as below,
> 
> UIProcess/API/C/CoordinatedGraphics/WKView.cpp
> UIProcess/API/C/WKPageConfigurationRef.cpp
> 
> then when I run check-webkit-style script, I meet the log like this.
> 
> Source/WebKit2/PlatformEfl.cmake:69:  Alphabetical sorting problem.
> "UIProcess/API/C/WKPageConfigurationRef.cpp" should be before
> "UIProcess/API/C/CoordinatedGraphics/WKView.cpp".
> 
> It seems that WKPageConfigurationRef.cpp is precede to WKView.cpp 
> because the former is file name and the latter is an intermediate path name
> I think.
> 
> So I guess the current alphabetical order is the right one.

Yes, it just needed to have a empty line. :) I fixed it.

http://trac.webkit.org/changeset/188751/trunk/Source/WebKit2/PlatformEfl.cmake

[Joonghun Park]

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #2)
> > > Comment on attachment 259565 [details]
> > > Patch
> > > 
> > > View in context:
> > > https://bugs.webkit.org/attachment.cgi?id=259565&action=review
> > > 
> > > > Source/WebKit2/PlatformEfl.cmake:68
> > > > +    UIProcess/API/C/WKPageConfigurationRef.cpp
> > > 
> > > Wrong alphabet order.
> > 
> > If I place files as below,
> > 
> > UIProcess/API/C/CoordinatedGraphics/WKView.cpp
> > UIProcess/API/C/WKPageConfigurationRef.cpp
> > 
> > then when I run check-webkit-style script, I meet the log like this.
> > 
> > Source/WebKit2/PlatformEfl.cmake:69:  Alphabetical sorting problem.
> > "UIProcess/API/C/WKPageConfigurationRef.cpp" should be before
> > "UIProcess/API/C/CoordinatedGraphics/WKView.cpp".
> > 
> > It seems that WKPageConfigurationRef.cpp is precede to WKView.cpp 
> > because the former is file name and the latter is an intermediate path name
> > I think.
> > 
> > So I guess the current alphabetical order is the right one.
> 
> Yes, it just needed to have a empty line. :) I fixed it.
> 
> http://trac.webkit.org/changeset/188751/trunk/Source/WebKit2/PlatformEfl.
> cmake

Ah, I missed the empty line. Thank you :)

[Michael Catanzaro]

Thanks Joonghun. I moved it from PlatformEfl.cmake to CMakeLists.txt in r188826, since it's needed by every port.