WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
147996
Use WKPageConfigurationRef in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=147996
Summary
Use WKPageConfigurationRef in WebKitTestRunner
Anders Carlsson
Reported
2015-08-13 15:49:23 PDT
Use WKPageConfigurationRef in WebKitTestRunner
Attachments
Patch
(1.62 KB, patch)
2015-08-13 15:50 PDT
,
Anders Carlsson
no flags
Details
Formatted Diff
Diff
Patch
(11.37 KB, patch)
2015-08-13 16:09 PDT
,
Anders Carlsson
no flags
Details
Formatted Diff
Diff
Patch
(20.01 KB, patch)
2015-08-13 17:08 PDT
,
Anders Carlsson
no flags
Details
Formatted Diff
Diff
Patch
(16.76 KB, patch)
2015-08-20 16:37 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Patch
(17.73 KB, patch)
2015-08-20 16:40 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Patch
(17.96 KB, patch)
2015-08-20 16:56 PDT
,
Tim Horton
no flags
Details
Formatted Diff
Diff
Show Obsolete
(5)
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2015-08-13 15:50:21 PDT
Created
attachment 258944
[details]
Patch
Anders Carlsson
Comment 2
2015-08-13 16:09:03 PDT
Created
attachment 258947
[details]
Patch
Anders Carlsson
Comment 3
2015-08-13 17:08:06 PDT
Created
attachment 258959
[details]
Patch
Sam Weinig
Comment 4
2015-08-14 09:29:27 PDT
Comment on
attachment 258959
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=258959&action=review
> Tools/WebKitTestRunner/TestController.h:235 > WKRetainPtr<WKContextRef> m_context; > WKRetainPtr<WKPageGroupRef> m_pageGroup;
Since you can get the context and page group from the configuration, is it worth storing them here?
Sam Weinig
Comment 5
2015-08-19 18:46:11 PDT
Comment on
attachment 258959
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=258959&action=review
> Source/WebKit2/UIProcess/API/Cocoa/WKView.h:-57 > -#if TARGET_OS_IPHONE > -- (id)initWithFrame:(CGRect)frame processGroup:(WKProcessGroup *)processGroup browsingContextGroup:(WKBrowsingContextGroup *)browsingContextGroup; > -- (id)initWithFrame:(CGRect)frame processGroup:(WKProcessGroup *)processGroup browsingContextGroup:(WKBrowsingContextGroup *)browsingContextGroup relatedToView:(WKView *)relatedView; > -#else
Can we do this in another patch?
> Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:39 > -- (id)initWithFrame:(CGRect)frame contextRef:(WKContextRef)contextRef pageGroupRef:(WKPageGroupRef)pageGroupRef; > -- (id)initWithFrame:(CGRect)frame contextRef:(WKContextRef)contextRef pageGroupRef:(WKPageGroupRef)pageGroupRef relatedToPage:(WKPageRef)relatedPage; > +- (id)initWithFrame:(CGRect)frame configurationRef:(WKPageConfigurationRef)configuration;
Can we do this in another patch?
> Source/WebKit2/UIProcess/API/mac/WKView.mm:4007 > - Ref<API::PageConfiguration> configuration = *toImpl(configurationRef); > + Ref<API::PageConfiguration> configuration = toImpl(configurationRef)->copy();
This is a good change, but unrelated. Can you break it out?
Tim Horton
Comment 6
2015-08-20 16:37:12 PDT
Created
attachment 259520
[details]
Patch
Tim Horton
Comment 7
2015-08-20 16:40:11 PDT
Created
attachment 259522
[details]
Patch
Tim Horton
Comment 8
2015-08-20 16:56:40 PDT
Created
attachment 259526
[details]
Patch
Tim Horton
Comment 9
2015-08-20 17:01:48 PDT
http://trac.webkit.org/changeset/188718
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug