Bug 147996 - Use WKPageConfigurationRef in WebKitTestRunner
Summary: Use WKPageConfigurationRef in WebKitTestRunner
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-13 15:49 PDT by Anders Carlsson
Modified: 2015-08-27 18:38 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.62 KB, patch)
2015-08-13 15:50 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (11.37 KB, patch)
2015-08-13 16:09 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (20.01 KB, patch)
2015-08-13 17:08 PDT, Anders Carlsson
no flags Details | Formatted Diff | Diff
Patch (16.76 KB, patch)
2015-08-20 16:37 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (17.73 KB, patch)
2015-08-20 16:40 PDT, Tim Horton
no flags Details | Formatted Diff | Diff
Patch (17.96 KB, patch)
2015-08-20 16:56 PDT, Tim Horton
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-08-13 15:49:23 PDT
Use WKPageConfigurationRef in WebKitTestRunner
Comment 1 Anders Carlsson 2015-08-13 15:50:21 PDT
Created attachment 258944 [details]
Patch
Comment 2 Anders Carlsson 2015-08-13 16:09:03 PDT
Created attachment 258947 [details]
Patch
Comment 3 Anders Carlsson 2015-08-13 17:08:06 PDT
Created attachment 258959 [details]
Patch
Comment 4 Sam Weinig 2015-08-14 09:29:27 PDT
Comment on attachment 258959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258959&action=review

> Tools/WebKitTestRunner/TestController.h:235
>      WKRetainPtr<WKContextRef> m_context;
>      WKRetainPtr<WKPageGroupRef> m_pageGroup;

Since you can get the context and page group from the configuration, is it worth storing them here?
Comment 5 Sam Weinig 2015-08-19 18:46:11 PDT
Comment on attachment 258959 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258959&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKView.h:-57
> -#if TARGET_OS_IPHONE
> -- (id)initWithFrame:(CGRect)frame processGroup:(WKProcessGroup *)processGroup browsingContextGroup:(WKBrowsingContextGroup *)browsingContextGroup;
> -- (id)initWithFrame:(CGRect)frame processGroup:(WKProcessGroup *)processGroup browsingContextGroup:(WKBrowsingContextGroup *)browsingContextGroup relatedToView:(WKView *)relatedView;
> -#else

Can we do this in another patch?

> Source/WebKit2/UIProcess/API/Cocoa/WKViewPrivate.h:39
> -- (id)initWithFrame:(CGRect)frame contextRef:(WKContextRef)contextRef pageGroupRef:(WKPageGroupRef)pageGroupRef;
> -- (id)initWithFrame:(CGRect)frame contextRef:(WKContextRef)contextRef pageGroupRef:(WKPageGroupRef)pageGroupRef relatedToPage:(WKPageRef)relatedPage;
> +- (id)initWithFrame:(CGRect)frame configurationRef:(WKPageConfigurationRef)configuration;

Can we do this in another patch?

> Source/WebKit2/UIProcess/API/mac/WKView.mm:4007
> -    Ref<API::PageConfiguration> configuration = *toImpl(configurationRef);
> +    Ref<API::PageConfiguration> configuration = toImpl(configurationRef)->copy();

This is a good change, but unrelated. Can you break it out?
Comment 6 Tim Horton 2015-08-20 16:37:12 PDT
Created attachment 259520 [details]
Patch
Comment 7 Tim Horton 2015-08-20 16:40:11 PDT
Created attachment 259522 [details]
Patch
Comment 8 Tim Horton 2015-08-20 16:56:40 PDT
Created attachment 259526 [details]
Patch
Comment 9 Tim Horton 2015-08-20 17:01:48 PDT
http://trac.webkit.org/changeset/188718