Bug 148195 – Standalone image documents should send their size to the UIClient just like standalone media documents

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Beth Dakin]

Standalone image documents should send their size to the UIClient just like standalone media documents

rdar://problem/21951253

[Beth Dakin]

Created attachment 259410 [details]
Patch

[Beth Dakin]

Created attachment 259420 [details]
Patch

[Tim Horton]

Comment on attachment 259420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259420&action=review

> Source/WebCore/page/ChromeClient.h:459
> +    virtual void imageDocumentSizeChanged(const WebCore::IntSize&) { }
>  #if ENABLE(VIDEO)
>      virtual void mediaDocumentNaturalSizeChanged(const WebCore::IntSize&) { }

Any reason these aren't combined?

[Beth Dakin]

Thanks Tim! http://trac.webkit.org/changeset/188693

[Xabier Rodríguez Calvar]

This commit is breaking (at least) GTK+ compilation.

[Beth Dakin]

(In reply to comment #5)
> This commit is breaking (at least) GTK+ compilation.

Do you have a build failure log?

[Xabier Rodríguez Calvar]

(In reply to comment #6)
> (In reply to comment #5)
> > This commit is breaking (at least) GTK+ compilation.
> 
> Do you have a build failure log?

It seems that this problem got fixed somehow. Now the problem is another unrelated one.

[Csaba Osztrogonác]

Just to document, the EFL build was fixed by https://trac.webkit.org/changeset/188738 and the GTK was fixed by https://trac.webkit.org/changeset/188740