Bug 148195 - Standalone image documents should send their size to the UIClient just like standalone media documents
Summary: Standalone image documents should send their size to the UIClient just like s...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 148279 148424
Blocks:
  Show dependency tree / graph
 
Reported: 2015-08-19 15:00 PDT by Beth Dakin
Modified: 2015-08-26 01:43 PDT (History)
9 users (show)

See Also:

Attachments
Patch (12.18 KB, patch)
2015-08-19 15:04 PDT, Beth Dakin 		no flags Details | Formatted Diff | Diff
Patch (11.95 KB, patch)
2015-08-19 15:43 PDT, Beth Dakin 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2015-08-19 15:00:56 PDT 
Standalone image documents should send their size to the UIClient just like standalone media documents

rdar://problem/21951253
Comment 1 Beth Dakin 2015-08-19 15:04:16 PDT 
Created attachment 259410 [details]
Patch
Comment 2 Beth Dakin 2015-08-19 15:43:31 PDT 
Created attachment 259420 [details]
Patch
Comment 3 Tim Horton 2015-08-19 15:48:21 PDT 
Comment on attachment 259420 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259420&action=review

> Source/WebCore/page/ChromeClient.h:459
> +    virtual void imageDocumentSizeChanged(const WebCore::IntSize&) { }
>  #if ENABLE(VIDEO)
>      virtual void mediaDocumentNaturalSizeChanged(const WebCore::IntSize&) { }

Any reason these aren't combined?
Comment 4 Beth Dakin 2015-08-20 11:46:44 PDT 
Thanks Tim! http://trac.webkit.org/changeset/188693
Comment 5 Xabier Rodríguez Calvar 2015-08-21 01:58:21 PDT 
This commit is breaking (at least) GTK+ compilation.
Comment 6 Beth Dakin 2015-08-21 10:42:05 PDT 
(In reply to comment #5)
> This commit is breaking (at least) GTK+ compilation.

Do you have a build failure log?
Comment 7 Xabier Rodríguez Calvar 2015-08-24 01:16:05 PDT 
(In reply to comment #6)
> (In reply to comment #5)
> > This commit is breaking (at least) GTK+ compilation.
> 
> Do you have a build failure log?

It seems that this problem got fixed somehow. Now the problem is another unrelated one.
Comment 8 Csaba Osztrogonác 2015-08-26 01:43:44 PDT 
Just to document, the EFL build was fixed by https://trac.webkit.org/changeset/188738 and the GTK was fixed by https://trac.webkit.org/changeset/188740