Bug 148424 - Fix the !ENABLE(VIDEO) build after r188693
Summary: Fix the !ENABLE(VIDEO) build after r188693
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
Depends on:
Blocks: 148195
  Show dependency treegraph
Reported: 2015-08-25 02:48 PDT by Csaba Osztrogonác
Modified: 2015-08-25 11:13 PDT (History)
3 users (show)

See Also:

Patch (1.38 KB, patch)
2015-08-25 02:52 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-08-25 02:48:49 PDT
http://trac.webkit.org/changeset/188693 broke the !ENABLE(VIDEO) build,
because ChromeClient::imageOrMediaDocumentSizeChanged() is defined
inside ENABLE(VIDEO) guard, but is overriden unconfitionally:

../../Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.h:328:18: error: 'virtual void WebKit::WebChromeClient::imageOrMediaDocumentSizeChanged(const WebCore::IntSize&)' marked override, but does not override
Comment 1 Csaba Osztrogonác 2015-08-25 02:52:19 PDT
Created attachment 259834 [details]
Comment 2 WebKit Commit Bot 2015-08-25 11:13:20 PDT
Comment on attachment 259834 [details]

Clearing flags on attachment: 259834

Committed r188923: <http://trac.webkit.org/changeset/188923>
Comment 3 WebKit Commit Bot 2015-08-25 11:13:24 PDT
All reviewed patches have been landed.  Closing bug.