WebKit may keep outdated entry in the disk cache after a reload

[Chris Dumez]

WebKit may keep outdated entry in the disk cache after a reload in the following scenario:
1. We have an entry in the cache
2. The user reloads
3. We get a fresh resource from the network but this one is not cacheable

In this case, we should probably remove the cached entry to make it doesn't get used in the future.

[Chris Dumez]

rdar://problem/22299547

[Chris Dumez]

Created attachment 259320 [details]
Patch

[Antti Koivisto]

Comment on attachment 259320 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=259320&action=review

r=me

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp:519
>      // For simplicity we also don't reduce m_approximateSize on removals.
>      // The next synchronization will update everything.
>  
> +    removeFromPendingWriteOperations(key);
> +
>      serialBackgroundIOQueue().dispatch([this, key] {

You should also add bloom filter check here. Otherwise every non-cacheable resource generates disk I/O.

[Chris Dumez]

Created attachment 259373 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 259373 [details]
Patch

Clearing flags on attachment: 259373

Committed r188640: <http://trac.webkit.org/changeset/188640>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.