Bug 148003 – Move some commands from ./CMakeLists.txt to Source/cmake

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Alex Christensen]

When building everything separately like the Apple builds do, we need some functionality to be in Source/cmake instead of ./CMakeLists.txt to minimize the duplicate commands.

[Alex Christensen]

Created attachment 258958 [details]
Patch

[Brent Fulgham]

Comment on attachment 258958 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 258958 [details]
Patch

Clearing flags on attachment: 258958

Committed r188428: <http://trac.webkit.org/changeset/188428>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 148015

[Alex Christensen]

Created attachment 259172 [details]
Patch

[Alex Christensen]

This time I renamed OptionsWindows to OptionsWin and that fixed Windows.  I'll reland this once it passes another CMake EWS.

[Alex Christensen]

Recommitted to http://trac.webkit.org/changeset/188540

[Xabier Rodríguez Calvar]

This creates a problem with building GTK+ from scratch, as you don't get WTR and I think you don't get the launcher either.

[Xabier Rodríguez Calvar]

(In reply to comment #9)
> This creates a problem with building GTK+ from scratch, as you don't get WTR
> and I think you don't get the launcher either.

And even after reverting this, I don't get WTR, so I guess there's something else.

[Carlos Alberto Lopez Perez]

Also with the perf tests:

$ Tools/Scripts/run-perf-tests --platform gtk --release
WebKitTestRunner was not found at /home/gardener/WebKit/WebKitBuild/Release/bin/WebKitTestRunner
Build not up to date for /home/gardener/WebKit/WebKitBuild/Release/bin/WebKitTestRunner


The issue is that WebKitTestRunner is not longer built:

$ find WebKitBuild/Release/ -type f -executable
WebKitBuild/Release/CMakeFiles/3.0.2/CMakeDetermineCompilerABI_C.bin
WebKitBuild/Release/CMakeFiles/3.0.2/CMakeDetermineCompilerABI_CXX.bin
WebKitBuild/Release/CMakeFiles/3.0.2/CompilerIdCXX/a.out
WebKitBuild/Release/CMakeFiles/3.0.2/CompilerIdC/a.out
WebKitBuild/Release/bin/WebKitNetworkProcess
WebKitBuild/Release/bin/jsc
WebKitBuild/Release/bin/WebKitDatabaseProcess
WebKitBuild/Release/bin/WebKitPluginProcess
WebKitBuild/Release/bin/WebKitPluginProcess2
WebKitBuild/Release/bin/LLIntOffsetsExtractor
WebKitBuild/Release/bin/WebKitWebProcess
WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18.2.4
WebKitBuild/Release/lib/libwebkit2gtkinjectedbundle.so
WebKitBuild/Release/lib/libgtest.so
WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.10.0


This is probably the issue causing the GTK perf bot to fail on all the tests


I'm going to open a bug for this regression

[Carlos Alberto Lopez Perez]

Reported: https://bugs.webkit.org/show_bug.cgi?id=148127