Bug 148127 – [CMake] REGRESSION(r188540): WebKitTestRunner is not longer built and all the tests (layout and perf) fail.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Alberto Lopez Perez]

Since r188540 WebKitTestRunner is not longer built and all the perf and layout tests fail.

$ find WebKitBuild/Release/ -type f -executable
WebKitBuild/Release/CMakeFiles/3.0.2/CMakeDetermineCompilerABI_C.bin
WebKitBuild/Release/CMakeFiles/3.0.2/CMakeDetermineCompilerABI_CXX.bin
WebKitBuild/Release/CMakeFiles/3.0.2/CompilerIdCXX/a.out
WebKitBuild/Release/CMakeFiles/3.0.2/CompilerIdC/a.out
WebKitBuild/Release/bin/WebKitNetworkProcess
WebKitBuild/Release/bin/jsc
WebKitBuild/Release/bin/WebKitDatabaseProcess
WebKitBuild/Release/bin/WebKitPluginProcess
WebKitBuild/Release/bin/WebKitPluginProcess2
WebKitBuild/Release/bin/LLIntOffsetsExtractor
WebKitBuild/Release/bin/WebKitWebProcess
WebKitBuild/Release/lib/libjavascriptcoregtk-4.0.so.18.2.4
WebKitBuild/Release/lib/libwebkit2gtkinjectedbundle.so
WebKitBuild/Release/lib/libgtest.so
WebKitBuild/Release/lib/libwebkit2gtk-4.0.so.37.10.0


$ Tools/Scripts/run-webkit-tests --gtk
Using port 'gtk-wk2'
Test configuration: <, x86, release>
Placing test results in /home/gardener/WebKit/WebKitBuild/Release/layout-test-results
Baseline search path: gtk -> wk2 -> generic
Using Release build
Pixel tests disabled
Regular timeout: 6000, slow test timeout: 30000
Command line: /home/gardener/WebKit/Tools/jhbuild/jhbuild-wrapper --gtk run /home/gardener/WebKit/WebKitBuild/Release/bin/WebKitTestRunner -

--lint-test-files warnings:
LayoutTests/platform/gtk/TestExpectations:565 Path does not exist. css3/masking/mask-svg-clipped-fragmentId.html
LayoutTests/platform/gtk/TestExpectations:938 Path does not exist. platform/gtk/editing/pasteboard/middle-button-paste.html
LayoutTests/platform/gtk/TestExpectations:1135 Path does not exist. css3/masking/mask-svg-invalid-fragmentId.html
LayoutTests/platform/gtk/TestExpectations:1163 Duplicate or ambiguous entry lines LayoutTests/platform/gtk/TestExpectations:1161 and LayoutTests/platform/gtk/TestExpectations:1163. media/video-controller-child-rate.html
LayoutTests/platform/gtk/TestExpectations:1738 Path does not exist. platform/gtk/accessibility/object-attributes.html
LayoutTests/platform/gtk/TestExpectations:1739 Path does not exist. platform/gtk/accessibility/title-and-alt.html
LayoutTests/platform/gtk/TestExpectations:2358 Path does not exist. fast/forms/input-auto-fill-button.html

Found 39949 tests; running 35578, skipping 4371.
WebKitTestRunner was not found at /home/gardener/WebKit/WebKitBuild/Release/bin/WebKitTestRunner
Build check failed


$ Tools/Scripts/run-perf-tests --platform gtk --release
WebKitTestRunner was not found at /home/gardener/WebKit/WebKitBuild/Release/bin/WebKitTestRunner
Build not up to date for /home/gardener/WebKit/WebKitBuild/Release/bin/WebKitTestRunner



This affects at least the GTK port, and probably also the EFL one (not checked).


The bots seems to be working because a clean build was still not triggered, so they are using the WebKitTestRunner from r188540-- however the perf bot is already crashing for all tests.

[Alex Christensen]

Created attachment 259284 [details]
Patch

[Alex Christensen]

Woah, my bad.  Does this fix it?

[Alex Christensen]

Created attachment 259285 [details]
Patch

[Alex Christensen]

http://trac.webkit.org/changeset/188589

[Carlos Alberto Lopez Perez]

(In reply to comment #4)
> http://trac.webkit.org/changeset/188589

And this broke the GTK build :(

[12/157] Linking CXX executable bin/WebKitTestRunner
FAILED: : && /usr/lib/ccache/clang++   -std=c++11 -fcolor-diagnostics -Qunused-arguments -O3 -DNDEBUG -fno-exceptions -fno-strict-aliasing -fno-rtti  -L/home/clopez/webkit/webkit/WebKitBuild/DependenciesGTK/Root/lib64  -fuse-ld=gold -Wl,--disable-new-dtags @CMakeFiles/WebKitTestRunner.rsp  -o bin/WebKitTestRunner  && :
Tools/WebKitTestRunner/CMakeFiles/WebKitTestRunner.dir/TestController.cpp.o:/home/clopez/webkit/.ccache/tmp/TestContro.tmp.trinity.14155.ii:function WTR::TestController::ensureViewSupportsOptionsForTest(WTR::TestInvocation const&): error: undefined reference to 'WTR::TestController::updatePlatformSpecificViewOptionsForTest(WTR::ViewOptions&, WTR::TestInvocation const&) const'
Tools/WebKitTestRunner/CMakeFiles/WebKitTestRunner.dir/TestController.cpp.o:/home/clopez/webkit/.ccache/tmp/TestContro.tmp.trinity.14155.ii:function WTR::TestController::viewOptionsForTest(WTR::TestInvocation const&) const: error: undefined reference to 'WTR::TestController::updatePlatformSpecificViewOptionsForTest(WTR::ViewOptions&, WTR::TestInvocation const&) const'
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/61366/steps/compile-webkit/logs/stdio

[Carlos Alberto Lopez Perez]

Ok....

The build error is unrelated to this CMake issue. 

Your last patch fixed the CMake issue that uncovered the build error caused by r188548 that was previously unnoticed

Reported the build error here: https://bugs.webkit.org/show_bug.cgi?id=148154

Closing this