Bug 147989 - Add WKWindowFeaturesRef and a new modern createNewPage UI client callback
Summary: Add WKWindowFeaturesRef and a new modern createNewPage UI client callback
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 148014
Blocks:
  Show dependency tree / graph
 
Reported: 2015-08-13 13:51 PDT by Anders Carlsson
Modified: 2015-08-17 16:40 PDT (History)
1 user (show)

See Also:

Attachments
Patch (46.01 KB, patch)
2015-08-13 13:58 PDT, Anders Carlsson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2015-08-13 13:51:03 PDT 
Add WKWindowFeaturesRef and a new modern createNewPage UI client callback
Comment 1 Anders Carlsson 2015-08-13 13:58:51 PDT 
Created attachment 258931 [details]
Patch
Comment 2 Tim Horton 2015-08-13 14:09:45 PDT 
Comment on attachment 258931 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258931&action=review

> Source/WebKit2/Platform/IPC/mac/ConnectionMac.mm:8
> - *    notice, this list of conditions and the following disclaimer.
> + *    notice, this list of ins and the following disclaimer.

NO.

> Source/WebKit2/UIProcess/API/C/WKPage.cpp:106
> +    typedef std::tuple<WKPageUIClientV0, WKPageUIClientV1, WKPageUIClientV2, WKPageUIClientV3, WKPageUIClientV4, WKPageUIClientV5, WKPageUIClientV6> Versions;

ouch
Comment 3 Anders Carlsson 2015-08-13 14:32:00 PDT 
Committed r188404: <http://trac.webkit.org/changeset/188404>
Comment 4 WebKit Commit Bot 2015-08-13 21:37:57 PDT 
Re-opened since this is blocked by bug 148014
Comment 5 Anders Carlsson 2015-08-17 16:40:10 PDT 
Committed r188553: <http://trac.webkit.org/changeset/188553>