Bug 147781 - Reduce uses of PassRefPtr in bindings
Summary: Reduce uses of PassRefPtr in bindings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 144092
  Show dependency treegraph
 
Reported: 2015-08-07 05:59 PDT by Gyuyoung Kim
Modified: 2015-08-07 22:39 PDT (History)
4 users (show)

See Also:


Attachments
Patch (37.33 KB, patch)
2015-08-07 06:00 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (37.38 KB, patch)
2015-08-07 07:34 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (39.35 KB, patch)
2015-08-07 08:02 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch (39.40 KB, patch)
2015-08-07 16:18 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-08-07 05:59:17 PDT
SSIA.
Comment 1 Gyuyoung Kim 2015-08-07 06:00:50 PDT
Created attachment 258488 [details]
Patch
Comment 2 Gyuyoung Kim 2015-08-07 07:34:52 PDT
Created attachment 258496 [details]
Patch
Comment 3 Gyuyoung Kim 2015-08-07 08:02:48 PDT
Created attachment 258499 [details]
Patch
Comment 4 Gyuyoung Kim 2015-08-07 16:18:11 PDT
Created attachment 258540 [details]
Patch
Comment 5 Chris Dumez 2015-08-07 18:44:37 PDT
Comment on attachment 258540 [details]
Patch

r=me but you need to rebaseline the bindings tests like so: Tools/Scripts/run-bindings-tests --reset-results
Comment 6 Gyuyoung Kim 2015-08-07 21:16:26 PDT
(In reply to comment #5)
> Comment on attachment 258540 [details]
> Patch
> 
> r=me but you need to rebaseline the bindings tests like so:
> Tools/Scripts/run-bindings-tests --reset-results

Thank you for review. BTW all tests are passed. So I don't know what tests should be rebaseline.
Comment 7 Chris Dumez 2015-08-07 21:43:38 PDT
Comment on attachment 258540 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=258540&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:903
> +            push(@headerContent, "    static RefPtr<NodeFilter> toWrapped(JSC::VM&, JSC::JSValue);\n");

You altered the bindings generator here so I assumed that the bindings tests needed rebaselining. If they don't then it likely means our test coverage isn't good enough.
Comment 8 Gyuyoung Kim 2015-08-07 21:50:04 PDT
Comment on attachment 258540 [details]
Patch

win-ews seems to be broken now. Let me check win bot after landing this patch.
Comment 9 WebKit Commit Bot 2015-08-07 22:39:23 PDT
Comment on attachment 258540 [details]
Patch

Clearing flags on attachment: 258540

Committed r188187: <http://trac.webkit.org/changeset/188187>
Comment 10 WebKit Commit Bot 2015-08-07 22:39:28 PDT
All reviewed patches have been landed.  Closing bug.