Bug 147636 - [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
Summary: [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build fail...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-08-04 11:17 PDT by Brent Fulgham
Modified: 2015-08-05 00:44 PDT (History)
6 users (show)

See Also:


Attachments
Patch (1.81 KB, patch)
2015-08-04 11:20 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2015-08-04 11:17:42 PDT
We started trying to capture build failures into our build log back in 2013, and added special logic for Visual Studio Express because the build driver was not emitting errors to stdout.

However, in Bug 140845 we switched to MSBuild for all builds, which handles this output properly.

Since MSBuild uses BuildOutput.htm directly, the file can be locked by MSBuild activity causing the overall build process to fail due to the 'die' command in the build-webkit Perl script.

We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.

Remove this unneeded (and bug-prone) code to improve the build reliability.
Comment 1 Brent Fulgham 2015-08-04 11:20:32 PDT
Created attachment 258186 [details]
Patch
Comment 2 Alex Christensen 2015-08-04 12:05:18 PDT
Comment on attachment 258186 [details]
Patch

r=me
I was thinking about doing this last week
Do you think this will help with https://bugs.webkit.org/show_bug.cgi?id=146628
Comment 3 WebKit Commit Bot 2015-08-04 12:11:04 PDT
Comment on attachment 258186 [details]
Patch

Clearing flags on attachment: 258186

Committed r187874: <http://trac.webkit.org/changeset/187874>
Comment 4 WebKit Commit Bot 2015-08-04 12:11:08 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Brent Fulgham 2015-08-04 12:18:07 PDT
(In reply to comment #2)
> Comment on attachment 258186 [details]
> Patch
> 
> r=me
> I was thinking about doing this last week
> Do you think this will help with
> https://bugs.webkit.org/show_bug.cgi?id=146628

That's my hope. I'm trying to track down any errors or differences in EWS versus the other builds.