Bug 146628 – [Win] Fix the broken clean build which makes the EWS unreliable

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Csaba Osztrogonác]

Apple Windows EWS rejects all patches with these false positive failure:

  /home/buildbot/WebKit/Source/WebCore/DerivedSources.make:893: recipe for target 'XMLViewerCSS.h' failed
  python /home/buildbot/WebKit/WebKitBuild/Release/include/private/JavaScriptCore/jsmin.py </home/buildbot/WebKit/Source/WebCore/inspector/CommandLineAPIModuleSource.js >> ./CommandLineAPIModuleSource.min.js
  python: can't open file '/home/buildbot/WebKit/WebKitBuild/Release/include/private/JavaScriptCore/jsmin.py': [Errno 2] No such file or directory
  /home/buildbot/WebKit/Source/WebCore/DerivedSources.make:904: recipe for target 'XMLViewerJS.h' failed
  make: *** [XMLViewerJS.h] Error 2
  python: can't open file '/home/buildbot/WebKit/WebKitBuild/Release/include/private/JavaScriptCore/inline-and-minify-stylesheets-and-scripts.py': [Errno 2] No such file or directory
  /home/buildbot/WebKit/Source/WebCore/DerivedSources.make:1205: recipe for target 'InspectorOverlayPage.h' failed
  make: *** [InspectorOverlayPage.h] Error 2
  python: can't open file '/home/buildbot/WebKit/WebKitBuild/Release/include/private/JavaScriptCore/jsmin.py': [Errno 2] No such file or directory
  /home/buildbot/WebKit/Source/WebCore/DerivedSources.make:1212: recipe for target 'CommandLineAPIModuleSource.h' failed
  make: *** [CommandLineAPIModuleSource.h] Error 2
  Failed to build /home/buildbot/WebKit/Source/WebCore/DerivedSources.make:  at build-generated-files.pl line 91.

[Radar WebKit Bug Importer]

<rdar://problem/21680676>

[Csaba Osztrogonác]

It seems it isn't an EWS issue, but a sesrious incremental build issue.
I managed to reproduce it on the Windows buildbots too: (with clean build)
- https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/71337
- https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/89353

[Csaba Osztrogonác]

Any plan to fix the Windows build? It isn't good that Windows 
EWS reports false positive build failures for each patch. :((

[Csaba Osztrogonác]

The clean build is still broken:
- https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/71403
- https://build.webkit.org/builders/Apple%20Win%20Debug%20%28Build%29/builds/89420

And the Win EWS still reports false positive failures due to this bug.

[Alexey Proskuryakov]

While this obviously needs to be fixed, I'm also puzzled about how this causes false positives on EWS.

[Csaba Osztrogonác]

The clean build is still broken:
https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/71684

And the EWS still reports false positive failures. :(

Are you planning to fix it in the future?

[Brent Fulgham]

(In reply to comment #6)
> The clean build is still broken:
> https://build.webkit.org/builders/Apple%20Win%20Release%20%28Build%29/builds/
> 71684
> 
> And the EWS still reports false positive failures. :(
> 
> Are you planning to fix it in the future?

Yes!

We've had trouble investigating this issue due to the whitelisting problem on our EWS bots. I am very hopeful that we will have that resolved today or tomorrow, at which point we can figure out what's going on here.

I have attempted to reproduce this build failure locally, and find that if I do a full rebuild, or delete my entire Windows build output directory and build, that I have NO PROBLEMS.

It's very frustrating. :-(

[Csaba Osztrogonác]

any update?

[Csaba Osztrogonác]

ping?

[Alexey Proskuryakov]

This is being worked on. Several other problems affecting Windows EWS got fixed in the meanwhile, including a networking setup issue and bug 147636.

[Csaba Osztrogonác]

It is already fixed.