Bug 147457 – Move locale information into FontDescription

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Move locale information into FontDescription

[Myles C. Maxfield]

Created attachment 257857 [details]
Patch

[Andreas Kling]

Comment on attachment 257857 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257857&action=review

r=me

> Source/WebCore/platform/graphics/FontDescription.cpp:68
> +    : m_families(1)
> +    , m_locale(initialLocale())
> +    , m_specifiedSize(0)
> +    , m_computedSize(0)
> +    , m_orientation(Horizontal)
> +    , m_nonCJKGlyphOrientation(NonCJKGlyphOrientationVerticalRight)
> +    , m_widthVariant(RegularWidth)
> +    , m_italic(FontItalicOff)
> +    , m_smallCaps(FontSmallCapsOff)
> +    , m_isAbsoluteSize(false)
> +    , m_weight(FontWeightNormal)
> +    , m_renderingMode(NormalRenderingMode)
> +    , m_kerning(AutoKerning)
> +    , m_commonLigaturesState(NormalLigaturesState)
> +    , m_discretionaryLigaturesState(NormalLigaturesState)
> +    , m_historicalLigaturesState(NormalLigaturesState)
> +    , m_keywordSize(0)
> +    , m_fontSmoothing(AutoSmoothing)
> +    , m_textRendering(AutoTextRendering)
> +    , m_isSpecifiedFont(false)
> +    , m_script(localeToScriptCodeForFontSelection(m_locale))
> +    , m_fontSynthesis(initialFontSynthesis())

Can we move all these initializers to the member declarations instead? ({ })

[Myles C. Maxfield]

Committed r187626: <http://trac.webkit.org/changeset/187626>

[Myles C. Maxfield]

Reverted in https://bugs.webkit.org/show_bug.cgi?id=149898

[Myles C. Maxfield]

Created attachment 265254 [details]
Retry

[WebKit Commit Bot]

Comment on attachment 265254 [details]
Retry

Rejecting attachment 265254 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 265254, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

/Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://webkit-queues.webkit.org/results/412577

[Myles C. Maxfield]

Committed r192290: <http://trac.webkit.org/changeset/192290>