Bug 147430 - Clean up makeFontCascadeCacheKey()
Summary: Clean up makeFontCascadeCacheKey()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on: 147427
Blocks: 147457
  Show dependency tree / graph
 
Reported: 2015-07-29 18:47 PDT by Myles C. Maxfield
Modified: 2015-09-25 09:12 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.82 KB, patch)
2015-07-29 18:51 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (4.76 KB, patch)
2015-07-30 14:47 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2015-07-29 18:47:59 PDT 
Clean up makeFontCascadeCacheKey()
Comment 1 Myles C. Maxfield 2015-07-29 18:51:46 PDT 
Created attachment 257799 [details]
Patch
Comment 2 Myles C. Maxfield 2015-07-30 14:47:24 PDT 
Created attachment 257855 [details]
Patch
Comment 3 Benjamin Poulain 2015-07-30 15:17:21 PDT 
Comment on attachment 257855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257855&action=review

> Source/WebCore/platform/graphics/FontCache.h:85
> +        return static_cast<unsigned>(description.script()) << 9
> +            | static_cast<unsigned>(description.smallCaps()) << 8
> +            | static_cast<unsigned>(description.fontSynthesis()) << 6

This seems so fragile :(
But I can't find a better way :(
Comment 4 WebKit Commit Bot 2015-07-30 16:07:16 PDT 
Comment on attachment 257855 [details]
Patch

Clearing flags on attachment: 257855

Committed r187615: <http://trac.webkit.org/changeset/187615>
Comment 5 WebKit Commit Bot 2015-07-30 16:07:27 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Chris Dumez 2015-09-24 18:53:34 PDT 
Rolled out in <https://trac.webkit.org/r190232> because it seems to have caused a >1% regression on PLT (see rdar://problem/22657123).
Comment 7 Beth Dakin 2015-09-24 22:12:11 PDT 
(In reply to comment #6)
> Rolled out in <https://trac.webkit.org/r190232> because it seems to have
> caused a >1% regression on PLT (see rdar://problem/22657123).

This rollout seems to have caused fast/css3-text/font-synthesis.html to start failing.
Comment 8 Beth Dakin 2015-09-24 22:15:43 PDT 
I marked the test as failing for now: http://trac.webkit.org/changeset/190236
Comment 9 Chris Dumez 2015-09-25 09:12:39 PDT 
Remanded in <http://trac.webkit.org/changeset/190242> as the rollout did not help the PLT recover.