Bug 147169 - Switch WinCairo build to use CMake
Summary: Switch WinCairo build to use CMake
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-21 15:55 PDT by Alex Christensen
Modified: 2015-07-23 10:28 PDT (History)
3 users (show)

See Also:


Attachments
Patch (11.06 KB, patch)
2015-07-21 16:05 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff
Patch (4.28 KB, patch)
2015-07-22 10:31 PDT, Alex Christensen
bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2015-07-21 15:55:55 PDT
It works well enough to automate and find out what goes wrong.  We can polish it more once we have a bot that builds WebKit on Windows with CMake.

Still needing to be done:
1) Make WebCore's derived sources parallel and not run every time we build anything in WebCore.
2) Get all the features working.  WebGL will be especially tricky because that will require a CMake build system for ANGLE that is quite different.
3) Get testing working.
Comment 1 Alex Christensen 2015-07-21 16:05:25 PDT
Created attachment 257213 [details]
Patch
Comment 2 Alex Christensen 2015-07-21 17:19:12 PDT
Comment on attachment 257213 [details]
Patch

I moved most of this to https://bugs.webkit.org/show_bug.cgi?id=147174
I'll do the switch after that lands.
Comment 3 Alex Christensen 2015-07-22 10:31:53 PDT
Created attachment 257281 [details]
Patch
Comment 4 Brent Fulgham 2015-07-22 10:48:58 PDT
Comment on attachment 257281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257281&action=review

Looks great! r=me, but please correct the spacing on that concatenation operator.

> Tools/Scripts/build-webkit:264
> +            $result = buildVisualStudioProject("WebKitBuild/".configuration()."/WebKit.sln", $clean);

I think you should have spaces around the concatenation operator (.)
Comment 5 Alex Christensen 2015-07-22 11:16:13 PDT
http://trac.webkit.org/changeset/187169
Comment 6 Csaba Osztrogonác 2015-07-22 23:29:29 PDT
(In reply to comment #5)
> http://trac.webkit.org/changeset/187169

It broke the Apple Windows build. Don't you watch the bots when you land patches?
Comment 7 Alex Christensen 2015-07-23 10:28:53 PDT
I did not in this case.  I should have.  Fix committed to http://trac.webkit.org/changeset/187235