Bug 147169 – Switch WinCairo build to use CMake

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Alex Christensen]

It works well enough to automate and find out what goes wrong.  We can polish it more once we have a bot that builds WebKit on Windows with CMake.

Still needing to be done:
1) Make WebCore's derived sources parallel and not run every time we build anything in WebCore.
2) Get all the features working.  WebGL will be especially tricky because that will require a CMake build system for ANGLE that is quite different.
3) Get testing working.

[Alex Christensen]

Created attachment 257213 [details]
Patch

[Alex Christensen]

Comment on attachment 257213 [details]
Patch

I moved most of this to https://bugs.webkit.org/show_bug.cgi?id=147174
I'll do the switch after that lands.

[Alex Christensen]

Created attachment 257281 [details]
Patch

[Brent Fulgham]

Comment on attachment 257281 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=257281&action=review

Looks great! r=me, but please correct the spacing on that concatenation operator.

> Tools/Scripts/build-webkit:264
> +            $result = buildVisualStudioProject("WebKitBuild/".configuration()."/WebKit.sln", $clean);

I think you should have spaces around the concatenation operator (.)

[Alex Christensen]

http://trac.webkit.org/changeset/187169

[Csaba Osztrogonác]

(In reply to comment #5)
> http://trac.webkit.org/changeset/187169

It broke the Apple Windows build. Don't you watch the bots when you land patches?

[Alex Christensen]

I did not in this case.  I should have.  Fix committed to http://trac.webkit.org/changeset/187235