https://bugs.webkit.org/show_bug.cgi?id=147169 has a lot of things going on at the same time. It fixes some quirks and switches the WinCairo build to use CMake by default. Let's fix the quirks in a separate patch.
Created attachment 257220 [details] Patch
Created attachment 257222 [details] Patch
Created attachment 257227 [details] Patch
Created attachment 257237 [details] Patch
Comment on attachment 257237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257237&action=review > Tools/CMakeLists.txt:31 > +#FIXME: Get DumpRenderTree working with CMake. Need indentation ? > Tools/WinLauncher/CMakeLists.txt:51 > +target_link_libraries(WinLauncher shlwapi) Just question. Doesn't *WinLauncher* excutable need to link *WinLauncherLib* ?
Comment on attachment 257237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=257237&action=review >> Tools/CMakeLists.txt:31 >> +#FIXME: Get DumpRenderTree working with CMake. > > Need indentation ? Sure. >> Tools/WinLauncher/CMakeLists.txt:51 >> +target_link_libraries(WinLauncher shlwapi) > > Just question. Doesn't *WinLauncher* excutable need to link *WinLauncherLib* ? It doesn't. DLLLauncherMain.cpp looks for a dll with the same name as the current executable and loads it with LoadLibraryW.
Created attachment 257276 [details] Patch
Comment on attachment 257276 [details] Patch win ews failure seems unrelated. cq+ and will check windows build bots in a half hour or so.
http://trac.webkit.org/changeset/187161