Bug 146616 - Web Inspector: Mark console filters that have unseen messages by colored dots
Summary: Web Inspector: Mark console filters that have unseen messages by colored dots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-07-04 20:47 PDT by Nikita Vasilyev
Modified: 2015-07-06 08:09 PDT (History)
8 users (show)

See Also:

Attachments
[Image] Expected (31.54 KB, image/png)
2015-07-04 20:47 PDT, Nikita Vasilyev 		no flags Details
Test page (for manual testing) (241 bytes, text/html)
2015-07-06 05:49 PDT, Nikita Vasilyev 		no flags Details
Patch (2.40 KB, patch)
2015-07-06 05:58 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
[Animated GIF] With the patch applied (1.05 MB, image/gif)
2015-07-06 06:03 PDT, Nikita Vasilyev 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2015-07-04 20:47:29 PDT 
Created attachment 256168 [details]
[Image] Expected

"Web Inspector: Console should indicate if you have unseen messages in console due to filters" (https://bugs.webkit.org/show_bug.cgi?id=143166) introduced colored borders. I suggest to replace them with colored dots to make it more esthetically pleasing.
Comment 1 Radar WebKit Bug Importer 2015-07-04 20:47:40 PDT 
<rdar://problem/21675741>
Comment 2 Timothy Hatcher 2015-07-04 23:06:49 PDT 
I like the dots. Post a patch?
Comment 3 Nikita Vasilyev 2015-07-06 05:49:01 PDT 
Created attachment 256209 [details]
Test page (for manual testing)
Comment 4 Nikita Vasilyev 2015-07-06 05:58:19 PDT 
Created attachment 256211 [details]
Patch
Comment 5 Nikita Vasilyev 2015-07-06 06:03:36 PDT 
Created attachment 256212 [details]
[Animated GIF] With the patch applied
Comment 6 Timothy Hatcher 2015-07-06 07:19:33 PDT 
Comment on attachment 256211 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256211&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.css:27
> +    content: '';

Nit: Double quotes.
Comment 7 WebKit Commit Bot 2015-07-06 08:09:39 PDT 
Comment on attachment 256211 [details]
Patch

Clearing flags on attachment: 256211

Committed r186354: <http://trac.webkit.org/changeset/186354>
Comment 8 WebKit Commit Bot 2015-07-06 08:09:44 PDT 
All reviewed patches have been landed.  Closing bug.