Bug 143166 – Web Inspector: Console should indicate if you have unseen messages in console due to filters

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Console should indicate if you have unseen messages in console due to filters.

I frequently think "where are my messages" before noticing that there is a filter that is hiding them. I've frequently had people come to me with the same problem. We should better indicate when a filter is hiding messages.

[Radar WebKit Bug Importer]

<rdar://problem/20335055>

[Devin Rousso]

Created attachment 256050 [details]
Patch

[Timothy Hatcher]

Can you post a screenshot?

[Timothy Hatcher]

Comment on attachment 256050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256050&action=review

> Source/WebInspectorUI/UserInterface/Views/LogContentView.css:35
> +    border-color: rgba(224, 164, 4, 0.9);

Why rgba here and not for the others?

> Source/WebInspectorUI/UserInterface/Views/LogContentView.js:324
> +    _determineMessageLevel: function(level)

_scopeFromMessageLevel?

[Devin Rousso]

Comment on attachment 256050 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=256050&action=review

>> Source/WebInspectorUI/UserInterface/Views/LogContentView.css:35
>> +    border-color: rgba(224, 164, 4, 0.9);
> 
> Why rgba here and not for the others?

I was originally using the color of the warning icon in the inspector status area, but I'll look to see if I can find a better color.

[Devin Rousso]

Created attachment 256150 [details]
After Patch is applied

[Devin Rousso]

Created attachment 256151 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 256151 [details]
Patch

Clearing flags on attachment: 256151

Committed r186283: <http://trac.webkit.org/changeset/186283>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.