Bug 146591 - Use Ref/RefPtr instead of PassRefPtr in WebKit2 - 2
Summary: Use Ref/RefPtr instead of PassRefPtr in WebKit2 - 2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 144092
  Show dependency tree / graph
 
Reported: 2015-07-03 07:27 PDT by Gyuyoung Kim
Modified: 2015-07-08 22:05 PDT (History)
3 users (show)

See Also:

Attachments
Patch (84.45 KB, patch)
2015-07-03 07:30 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (80.30 KB, patch)
2015-07-03 23:36 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-07-03 07:27:51 PDT 
SSIA
Comment 1 Gyuyoung Kim 2015-07-03 07:30:23 PDT 
Created attachment 256101 [details]
Patch
Comment 2 Gyuyoung Kim 2015-07-03 23:36:06 PDT 
Created attachment 256140 [details]
Patch
Comment 3 WebKit Commit Bot 2015-07-08 19:32:27 PDT 
Comment on attachment 256140 [details]
Patch

Clearing flags on attachment: 256140

Committed r186566: <http://trac.webkit.org/changeset/186566>
Comment 4 WebKit Commit Bot 2015-07-08 19:32:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Brent Fulgham 2015-07-08 21:18:15 PDT 
This introduced a build failure in Windows:

..\..\win\Plugins\PluginView.cpp(855): error C2556: 'WTF::PassRefPtr<T> WebCore::PluginView::create(WebCore::Frame *,const WebCore::IntSize &,WebCore::HTMLPlugInElement *,const WebCore::URL &,const WTF::Vector<WTF::String,0,WTF::CrashOnOverflow,16> &,const WTF::Vector<WTF::String,0,WTF::CrashOnOverflow,16> &,const WTF::String &,bool)' : overloaded function differs only by return type from 'WTF::Ref<WebCore::PluginView> WebCore::PluginView::create(WebCore::Frame *,const WebCore::IntSize &,WebCore::HTMLPlugInElement *,const WebCore::URL &,const WTF::Vector<WTF::String,0,WTF::CrashOnOverflow,16> &,const WTF::Vector<WTF::String,0,WTF::CrashOnOverflow,16> &,const WTF::String &,bool)' [C:\cygwin\home\buildbot\slave\win-release\build\Source\WebKit\WebKit.vcxproj\WebKit\WebKit.vcxproj]
Comment 6 Brent Fulgham 2015-07-08 21:38:46 PDT 
dbates fixed it: <http://trac.webkit.org/changeset/186578>
Comment 7 Gyuyoung Kim 2015-07-08 22:05:57 PDT 
(In reply to comment #6)
> dbates fixed it: <http://trac.webkit.org/changeset/186578>

Thank you for fixing it.