Bug 146147 - [WinCairo] Null pointer crash in BitmapTexture::updateContents.
Summary: [WinCairo] Null pointer crash in BitmapTexture::updateContents.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 102011 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-06-19 07:19 PDT by peavo
Modified: 2022-06-21 20:12 PDT (History)
9 users (show)

See Also:


Attachments
Patch (1.50 KB, patch)
2015-06-19 07:22 PDT, peavo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description peavo 2015-06-19 07:19:29 PDT
When I have a lot of WebViews open, and memory usage is high (> 700MB), I often get a null pointer exception in BitmapTexture::updateContents.
Comment 1 peavo 2015-06-19 07:22:56 PDT
Created attachment 255190 [details]
Patch
Comment 2 Brent Fulgham 2015-06-19 09:07:09 PDT
Comment on attachment 255190 [details]
Patch

r=me.
Comment 3 Brent Fulgham 2015-06-19 09:08:41 PDT
It looks like this null check is missing in a few places system-wide (not just WinCairo).
Comment 4 Brent Fulgham 2015-06-19 09:43:04 PDT
This bug was originally reported back in 2008! See Bug 22132. :-)
Comment 5 WebKit Commit Bot 2015-06-19 10:14:11 PDT
Comment on attachment 255190 [details]
Patch

Clearing flags on attachment: 255190

Committed r185752: <http://trac.webkit.org/changeset/185752>
Comment 6 WebKit Commit Bot 2015-06-19 10:14:16 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 peavo 2015-06-19 23:07:41 PDT
(In reply to comment #2)
> Comment on attachment 255190 [details]
> Patch
> 
> r=me.

Thanks!
Comment 8 peavo 2015-06-19 23:53:01 PDT
(In reply to comment #4)
> This bug was originally reported back in 2008! See Bug 22132. :-)

Thanks for fixing this, Brent :)
Comment 9 Fujii Hironori 2022-06-21 20:12:21 PDT
*** Bug 102011 has been marked as a duplicate of this bug. ***