Bug 102011 – [TEXMAP] Check imageBuffer Creation failure when updateBackingStore

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Layout and Rendering

[TEXMAP] Check imageBuffer Creation failure when updateBackingStore

Created attachment 173763 [details]
Patch

[Noam Rosenthal]

Comment on attachment 173763 [details]
Patch

The right way to fix it is to tile the dirtyRects before uploading them.
Your fix will create bugs along the way, like "Why does this layer not appear correctly on the screen" :)

(In reply to comment #2)
> (From update of attachment 173763 [details])
> The right way to fix it is to tile the dirtyRects before uploading them.
> Your fix will create bugs along the way, like "Why does this layer not appear correctly on the screen" :)

I totally agree with you. But in my opinion, not appearing layer would be better than crashing.

How about clipping the layer to some size just before calling setCompositedBounds in RenderLayerBacking::updateCompositedBounds?

[Noam Rosenthal]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 173763 [details] [details])
> > The right way to fix it is to tile the dirtyRects before uploading them.
> > Your fix will create bugs along the way, like "Why does this layer not appear correctly on the screen" :)
> 
> I totally agree with you. But in my opinion, not appearing layer would be better than crashing.
Maybe for a production branch - in webkit.org trunk we hold a higher standard - meaning a patch has to take things forward, not replace a bug with one symptom (crash) with a bug with another symptom (layers not appearing). 

> 
> How about clipping the layer to some size just before calling setCompositedBounds in RenderLayerBacking::updateCompositedBounds?
It's another hack. I will only accepts patches that take this code forward - workarounds only in extreme cases where the "good" solution is not trivial.

[Fujii Hironori]

*** This bug has been marked as a duplicate of bug 146147 ***