Bug 146014 - [SOUP] Fix return-type-c-linkage warning after r185553
Summary: [SOUP] Fix return-type-c-linkage warning after r185553
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Catanzaro
Depends on:
Blocks: 145121 145969
  Show dependency treegraph
Reported: 2015-06-16 04:11 PDT by Csaba Osztrogonác
Modified: 2015-06-19 16:26 PDT (History)
4 users (show)

See Also:

Patch (4.50 KB, patch)
2015-06-19 14:49 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2015-06-16 04:11:43 PDT
After http://trac.webkit.org/changeset/185553 we get
the following warning if we build WebKit with clang:

../../Source/WebCore/platform/network/soup/WebKitSoupRequestGeneric.h:61:33: warning: 'webkitSoupRequestGenericGetRequest' has C-linkage specified, but returns user-defined type 'const WebCore::ResourceRequest &' which is incompatible with C [-Wreturn-type-c-linkage]
const WebCore::ResourceRequest& webkitSoupRequestGenericGetRequest(WebKitSoupRequestGeneric*);
1 warning generated.
Comment 1 Michael Catanzaro 2015-06-19 14:47:04 PDT
As much as I hate to convert a nice reference into a pointer, the alternative is to move the G_END_DECLS up above those function declarations, and that would be weird.
Comment 2 Michael Catanzaro 2015-06-19 14:49:23 PDT
Created attachment 255229 [details]
Comment 3 WebKit Commit Bot 2015-06-19 16:26:35 PDT
Comment on attachment 255229 [details]

Clearing flags on attachment: 255229

Committed r185774: <http://trac.webkit.org/changeset/185774>
Comment 4 WebKit Commit Bot 2015-06-19 16:26:40 PDT
All reviewed patches have been landed.  Closing bug.