Bug 145969 - [SOUP] Custom URI schemes don't work for requests containing a fragment identifier
Summary: [SOUP] Custom URI schemes don't work for requests containing a fragment ident...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Soup
Depends on: 145968 146014 146075
Blocks:
  Show dependency treegraph
 
Reported: 2015-06-15 03:46 PDT by Carlos Garcia Campos
Modified: 2015-06-17 14:19 PDT (History)
2 users (show)

See Also:


Attachments
Patch (8.70 KB, patch)
2015-06-15 08:44 PDT, Carlos Garcia Campos
svillar: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2015-06-15 03:46:05 PDT
For URIs like foo:bar#baz, what the custom protocol manager receives in the UI process is foo:bar, so the user can't handle fragments. Wrote a test case for GTK, see:

/webkit2/WebKitWebContext/uri-scheme: **
ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:220:void testWebContextURIScheme(URISchemeTest*, gconstpointer): assertion failed (webkit_uri_scheme_request_get_uri(test->m_uriSchemeRequest.get()) == "echo:with#fragment"): ("echo:with" == "echo:with#fragment")
Comment 1 Carlos Garcia Campos 2015-06-15 08:44:54 PDT
Created attachment 254877 [details]
Patch
Comment 2 Sergio Villar Senin 2015-06-15 09:33:25 PDT
Comment on attachment 254877 [details]
Patch

r=me
Comment 3 Carlos Garcia Campos 2015-06-15 09:37:10 PDT
Committed r185553: <http://trac.webkit.org/changeset/185553>