Bug 146001 – Purge PassRefPtr with Ref or RefPtr in WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Gyuyoung Kim]

As step to remove PassRefPtr, this patch removes PassRefPtr in WebKit2. If function can't return nullptr, PassRefPtr is changed with Ref. If not, the function returns RefPtr.

[Gyuyoung Kim]

Created attachment 254920 [details]
Patch

[Gyuyoung Kim]

Created attachment 254922 [details]
Patch

[Gyuyoung Kim]

Created attachment 254929 [details]
Patch

[Gyuyoung Kim]

Created attachment 254930 [details]
Patch

[Gyuyoung Kim]

Created attachment 254932 [details]
Patch

[Darin Adler]

Comment on attachment 254932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254932&action=review

> Source/WebKit2/ChangeLog:8
> +        As step to remove PassRefPtr, this patch removes PassRefPtr in WebKit2.

This wording, which we have used on a lot of patches, is wrong. The patch does not remove these from WebKIt2. It reduces the use of them in WebKit2.

> Source/WebKit2/Shared/API/APINumber.h:39
> +    static RefPtr<Number> create(NumberType value)

Why RefPtr instead of Ref here?

> Source/WebKit2/Shared/API/APISecurityOrigin.h:50
>              return 0;

nullptr

> Source/WebKit2/UIProcess/WebPageProxy.cpp:4659
> +    callback->performCallbackWithReturnValue(data.size() ? API::SerializedScriptValue::adopt(data).ptr() : 0, hadException);

nullptr

[Gyuyoung Kim]

Created attachment 254994 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 254932 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254932&action=review

>> Source/WebKit2/ChangeLog:8
>> +        As step to remove PassRefPtr, this patch removes PassRefPtr in WebKit2.
> 
> This wording, which we have used on a lot of patches, is wrong. The patch does not remove these from WebKIt2. It reduces the use of them in WebKit2.

Yes, you are right. I fix this changelog. Let me write changelog in upcoming patch carefully.

>> Source/WebKit2/Shared/API/APINumber.h:39
>> +    static RefPtr<Number> create(NumberType value)
> 
> Why RefPtr instead of Ref here?

done.

>> Source/WebKit2/Shared/API/APISecurityOrigin.h:50
>>              return 0;
> 
> nullptr

done.

>> Source/WebKit2/UIProcess/WebPageProxy.cpp:4659
>> +    callback->performCallbackWithReturnValue(data.size() ? API::SerializedScriptValue::adopt(data).ptr() : 0, hadException);
> 
> nullptr

done.

[WebKit Commit Bot]

Comment on attachment 254994 [details]
Patch

Clearing flags on attachment: 254994

Committed r185637: <http://trac.webkit.org/changeset/185637>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.