font-variant: small-caps is not honored with web fonts
<rdar://problem/21314282>
Created attachment 254707 [details] Patch
Created attachment 254710 [details] Patch
Comment on attachment 254710 [details] Patch Attachment 254710 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6300169943384064 Number of test failures exceeded the failure limit.
Created attachment 254716 [details] Archive of layout-test-results from ews101 for mac-mavericks The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews101 Port: mac-mavericks Platform: Mac OS X 10.9.5
Comment on attachment 254710 [details] Patch Attachment 254710 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6032054462447616 Number of test failures exceeded the failure limit.
Created attachment 254717 [details] Archive of layout-test-results from ews107 for mac-mavericks-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-mavericks-wk2 Platform: Mac OS X 10.9.5
Comment on attachment 254710 [details] Patch Looks like a lot of tests are crashing.
Looks like the failures are Mavericks-specific
(In reply to comment #9) > Looks like the failures are Mavericks-specific Oh, whoops. r184899 is only applicable to particular operating systems.
Created attachment 254985 [details] Patch
Comment on attachment 254985 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=254985&action=review > Source/WebCore/platform/graphics/cocoa/FontCocoa.mm:314 > +#if !CORETEXT_WEB_FONTS Why is this not an ENABLE flag? > Source/WebCore/platform/text/TextFlags.h:31 > +// See https://bug-145873-attachments.webkit.org/attachment.cgi?id=254710 Did you mean to link to an attachment?
Is this a duplicate of bug 145802?
(In reply to comment #13) > Is this a duplicate of bug 145802? Yes. It looks like that's the original, but all the work is in this bug, so I'll reverse-dup that one to this one.
Comment on attachment 254985 [details] Patch Clearing flags on attachment: 254985 Committed r185632: <http://trac.webkit.org/changeset/185632>
All reviewed patches have been landed. Closing bug.
*** Bug 145802 has been marked as a duplicate of this bug. ***
This broke fast/writing-mode/broken-ideograph-small-caps.html on Yosemite. I'm going to land custom result, however please confirm that new results are good: https://build.webkit.org/results/Apple%20Yosemite%20Release%20WK1%20(Tests)/r185632%20(6094)/fast/writing-mode/broken-ideograph-small-caps-diff.txt
The difference between old and new results seems expected - we just get smaller letters for small caps. However, looking at image results that are checked in <https://build-safari.apple.com/results/Trunk%20Syrah%20Production%20WK1%20Tests/r185636_72857%20(22914)/retries/fast/writing-mode/broken-ideograph-small-caps-diffs.html>, we appear to have an earlier regression - small caps are incorrectly rotated. This happens even in Safari 7.1.6 on Mavericks. Could you please confirm whether the current behavior is wrong, and if so, file a new bug?
Way(In reply to comment #19) > The difference between old and new results seems expected - we just get > smaller letters for small caps. > > However, looking at image results that are checked in > <https://build-safari.apple.com/results/ > Trunk%20Syrah%20Production%20WK1%20Tests/r185636_72857%20(22914)/retries/ > fast/writing-mode/broken-ideograph-small-caps-diffs.html>, we appear to have > an earlier regression - small caps are incorrectly rotated. This happens > even in Safari 7.1.6 on Mavericks. > > Could you please confirm whether the current behavior is wrong, and if so, > file a new bug? Way ahead of you. I filed a bug about this last April. https://bugs.webkit.org/show_bug.cgi?id=143454
(In reply to comment #19) > The difference between old and new results seems expected - we just get > smaller letters for small caps. > > However, looking at image results that are checked in > <https://build-safari.apple.com/results/ > Trunk%20Syrah%20Production%20WK1%20Tests/r185636_72857%20(22914)/retries/ > fast/writing-mode/broken-ideograph-small-caps-diffs.html>, we appear to have > an earlier regression - small caps are incorrectly rotated. This happens > even in Safari 7.1.6 on Mavericks. > > Could you please confirm whether the current behavior is wrong, and if so, > file a new bug? Yes, this is a progression.