http://trac.webkit.org/changeset/185240 broke the ARM Linux builds because of missing setupArgumentsWithExecState implementations. I started work on it, patch is coming soon.
Created attachment 254484 [details] Patch build already tested, I'll set r? flag when testing is finished.
Comment on attachment 254484 [details] Patch all tests pass with the patch
Comment on attachment 254484 [details] Patch Is this for classic ARM? IIRC, I tried my patch on ARMv7. Thanks for fixing in any case.
(In reply to comment #3) > Comment on attachment 254484 [details] > Patch > > Is this for classic ARM? IIRC, I tried my patch on ARMv7. > > Thanks for fixing in any case. This build issue isn't related to the ARM/Thumb2 instruction set or v6/v7 architecture. On Linux we use ARM EABI and we have to align a 64-bit integer to even numbered register. EABI_32BIT_DUMMY_ARG macro ( == TrustedImm32(0) ) is responible for this alignment. But unfortunately we need more setupArgumentsWithExecState() because of the dummy argument.
Comment on attachment 254484 [details] Patch Clearing flags on attachment: 254484 Committed r185323: <http://trac.webkit.org/changeset/185323>
All reviewed patches have been landed. Closing bug.
(In reply to comment #4) > (In reply to comment #3) > > Comment on attachment 254484 [details] > > Patch > > > > Is this for classic ARM? IIRC, I tried my patch on ARMv7. > > > > Thanks for fixing in any case. > > This build issue isn't related to the ARM/Thumb2 instruction set or > v6/v7 architecture. On Linux we use ARM EABI and we have to align a > 64-bit integer to even numbered register. EABI_32BIT_DUMMY_ARG macro > ( == TrustedImm32(0) ) is responible for this alignment. But unfortunately > we need more setupArgumentsWithExecState() because of the dummy argument. Oh, I did not know about that. I'll try to remember that for next time.