Bug 145750 - Purge PassRefPtr in JavaScriptCore
Summary: Purge PassRefPtr in JavaScriptCore
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks: 144092
  Show dependency tree / graph
 
Reported: 2015-06-07 21:14 PDT by Gyuyoung Kim
Modified: 2015-06-08 19:18 PDT (History)
1 user (show)

See Also:

Attachments
Patch (53.95 KB, patch)
2015-06-07 21:20 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (48.60 KB, patch)
2015-06-08 00:54 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (50.70 KB, patch)
2015-06-08 09:04 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch (50.69 KB, patch)
2015-06-08 17:08 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for landing (50.52 KB, patch)
2015-06-08 18:16 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Patch for landing (50.51 KB, patch)
2015-06-08 19:16 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2015-06-07 21:14:57 PDT 
SSIA
Comment 1 Gyuyoung Kim 2015-06-07 21:20:58 PDT 
Created attachment 254470 [details]
Patch
Comment 2 Gyuyoung Kim 2015-06-08 00:54:39 PDT 
Created attachment 254478 [details]
Patch
Comment 3 Gyuyoung Kim 2015-06-08 09:04:39 PDT 
Created attachment 254495 [details]
Patch
Comment 4 Gyuyoung Kim 2015-06-08 17:08:59 PDT 
Created attachment 254525 [details]
Patch
Comment 5 Darin Adler 2015-06-08 17:22:20 PDT 
Comment on attachment 254525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=254525&action=review

> Source/JavaScriptCore/heap/EdenGCActivityCallback.h:32
> +#include <wtf/RefPtr.h>
> +

This change is not needed.
Comment 6 Gyuyoung Kim 2015-06-08 18:16:19 PDT 
Created attachment 254532 [details]
Patch for landing
Comment 7 WebKit Commit Bot 2015-06-08 19:02:12 PDT 
Comment on attachment 254532 [details]
Patch for landing

Rejecting attachment 254532 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 254532, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in Source/JavaScriptCore/ChangeLog contains OOPS!.

Full output: http://webkit-queues.appspot.com/results/6213330268061696
Comment 8 Gyuyoung Kim 2015-06-08 19:16:27 PDT 
Created attachment 254538 [details]
Patch for landing
Comment 9 Gyuyoung Kim 2015-06-08 19:18:22 PDT 
Comment on attachment 254538 [details]
Patch for landing

Clearing flags on attachment: 254538

Committed r185346: <http://trac.webkit.org/changeset/185346>
Comment 10 Gyuyoung Kim 2015-06-08 19:18:31 PDT 
All reviewed patches have been landed.  Closing bug.