Bug 145724 – [EFL][GTK] Fix build break since r185262

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

EFL and GTK ports have been broken since r185262.

[Gyuyoung Kim]

Created attachment 254410 [details]
Patch

[Gyuyoung Kim]

Created attachment 254411 [details]
Patch

[Gyuyoung Kim]

I'm not sure if this fix is correct. Anyone give me comment ?

[Michael Catanzaro]

Can we just get rid of those legacy directory functions? It's not clear to me why we need two different places for these.

[Gyuyoung Kim]

Created attachment 254421 [details]
Patch

[Gyuyoung Kim]

Created attachment 254422 [details]
Patch

[Gyuyoung Kim]

(In reply to comment #4)
> Can we just get rid of those legacy directory functions? It's not clear to
> me why we need two different places for these.

I'm not sure what is correct fix now. However I want to fix EFL and GTK as soon as possible. I'd like to land this patch, then how about fix correctly for each port ?

[Gyuyoung Kim]

Comment on attachment 254422 [details]
Patch

To make EFL and GTK bot to green for now, I land this patch though this may not correct fix. If there is wrong fix, please fix it on following patch.

[Gyuyoung Kim]

Created attachment 254432 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 254432 [details]
Patch

Clearing flags on attachment: 254432

Committed r185300: <http://trac.webkit.org/changeset/185300>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Carlos Garcia Campos]

Yes, this was indeed wrong, at least for GTK+ port that has API to se the disk cache directory. There are actually two problems here. One is that we need to override the disk cache directory after the WebProcessPool has been created, and the other problem is that disk cache directory has been removed from web process pool configuration. We need to bring it back while we have network support in the web process.

[Gyuyoung Kim]

(In reply to comment #12)
> Yes, this was indeed wrong, at least for GTK+ port that has API to se the
> disk cache directory. There are actually two problems here. One is that we
> need to override the disk cache directory after the WebProcessPool has been
> created, and the other problem is that disk cache directory has been removed
> from web process pool configuration. We need to bring it back while we have
> network support in the web process.

Thank you for your explanation. I will also follow this problem for EFL port too. Anyway now EFL and GTK bots are fine.

[Carlos Garcia Campos]

(In reply to comment #13)
> (In reply to comment #12)
> > Yes, this was indeed wrong, at least for GTK+ port that has API to se the
> > disk cache directory. There are actually two problems here. One is that we
> > need to override the disk cache directory after the WebProcessPool has been
> > created, and the other problem is that disk cache directory has been removed
> > from web process pool configuration. We need to bring it back while we have
> > network support in the web process.
> 
> Thank you for your explanation. I will also follow this problem for EFL port
> too. Anyway now EFL and GTK bots are fine.

Oh, right, I guess you need to append "webkit" to the disk cache directory for EFL in the UI process too.