Bug 145636 - Fix options in build-jsc for CMake builds
Summary: Fix options in build-jsc for CMake builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords:
Depends on: 145516
Blocks:
  Show dependency treegraph
 
Reported: 2015-06-03 23:18 PDT by Yusuke Suzuki
Modified: 2015-06-03 23:59 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.39 KB, patch)
2015-06-03 23:20 PDT, Yusuke Suzuki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2015-06-03 23:18:09 PDT
Fix options in build-jsc for CMake builds
Comment 1 Yusuke Suzuki 2015-06-03 23:20:54 PDT
Created attachment 254250 [details]
Patch
Comment 2 Gyuyoung Kim 2015-06-03 23:41:20 PDT
Comment on attachment 254250 [details]
Patch

I can't find why did r185110 also modify cmake port on bug 145516.
https://bugs.webkit.org/show_bug.cgi?id=145516


AFAIK, cmake port needs to use ON/OFF. If we set nothing, it is set to false.
http://www.cmake.org/cmake/help/v3.0/command/option.html
Comment 3 WebKit Commit Bot 2015-06-03 23:49:53 PDT
Comment on attachment 254250 [details]
Patch

Clearing flags on attachment: 254250

Committed r185194: <http://trac.webkit.org/changeset/185194>
Comment 4 WebKit Commit Bot 2015-06-03 23:49:58 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Gyuyoung Kim 2015-06-03 23:59:05 PDT
One more thing, if we don't set value for passing arguments, cmake generates build error as below,


~/WebKit$ Tools/Scripts/build-webkit --efl --cmakeargs="-DENABLE_INDEXED_DATABASE_IN_WORKERS"
Not searching for unused variables given on the command line.
Parse error in command line argument: -DENABLE_INDEXED_DATABASE_IN_WORKERS
Should be: VAR:type=value
CMake Error: No cmake script provided.
CMake Error: Problem processing arguments. Aborting.