Bug 145516 – build-jsc’s —cloop option is broken

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

After r183516, build-jsc --cloop no longer builds the CLOOP interpreter.  This is because it did not explicitly disable the JIT when --cloop is specified.

[Mark Lam]

We cannot land this fix until https://bugs.webkit.org/show_bug.cgi?id=145515 is resolved.  Otherwise, we’ll have a red CLoop bot.  In reality, we do have a red CLoop bot.  We just have not been building the CLoop and seeing it.

[Mark Lam]

Created attachment 254005 [details]
the patch.

[Mark Lam]

Created attachment 254006 [details]
patch 2: fixed non-ascii chars.

[WebKit Commit Bot]

Comment on attachment 254006 [details]
patch 2: fixed non-ascii chars.

Clearing flags on attachment: 254006

Committed r185066: <http://trac.webkit.org/changeset/185066>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Filip Pizlo]

This broke the FTL JIT build.  It's no longer possible to build with LLVM checked out into a local directory after this change.

I will roll this out unless you have a quick fix, since this prevents me from doing any work.

[WebKit Commit Bot]

Re-opened since this is blocked by bug 145543

[Mark Lam]

(In reply to comment #6)
> This broke the FTL JIT build.  It's no longer possible to build with LLVM
> checked out into a local directory after this change.
> 
> I will roll this out unless you have a quick fix, since this prevents me
> from doing any work.

As far as I can tell, this might be the issue:
1. Configurations/LLVMForJSC.xcconfig defines OTHER_LDFLAGS_LLVM = $(OTHER_LDFLAGS_LLVM_$(ENABLE_FTL_JIT)_$(CURRENT_ARCH));
2. This in turn is used to map to OTHER_LDFLAGS_LLVM_ENABLE_FTL_JIT_x86_64 which provides the list of libs to link against.

With the patch, the $ftlJIT case specifies ENABLE_FTL_JIT=ENABLE_FTL_JIT=1 to get the compiler option -DENABLE_FTL_JIT=1.  I suspect that this throws a monkey wrench into configuration setup above.

Once I change it to ENABLE_FTL_JIT=ENABLE_FTL_JIT, the issue is resolved.  I’ll move forward with this as the fix since -DENABLE_FTL_JIT implicitly defines the symbol to 1 anyway i.e. it’s the same as -DENABLE_FTL_JIT=1.

[Mark Lam]

Created attachment 254072 [details]
patch for re-landing.

[Mark Lam]

Patch re-landed in r185110: <http://trac.webkit.org/r185110>.