EFL API tests is broken now though, unfortunately it is hard to track what revision broke it because EFL buildbot was broken too. So now I can guess the EFL API test was broken between r184346 ~ r184367. We need to fix it ASAP.
Need to check below range.
- Begin : https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/21905
- End : https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/21921
Oops... EFL API tests work on xvfb....
I find what revision break EFL API test. r184357 did it because suppress build warning related with cmake.
However it looks TARGET_FILE property isn't supported by cmake 2.8.12 correctly yet.
Created attachment 254342 [details]
CC'ing Michael and Martin, I would like to revert r184357 at the moment. However if you guys know better fix, please let me know.
Yes, I think it is fine to revert for the moment. It's better to have test coverage.
Yes, go ahead and revert, although I wish we knew what was wrong. I did check to make sure we could use TARGET_FILE with cmake 2.8.12.
Comment on attachment 254342 [details]
Clearing flags on attachment: 254342
Committed r185281: <http://trac.webkit.org/changeset/185281>
All reviewed patches have been landed. Closing bug.