Bug 145018 - [CMake] Don't read the LOCATION property of targets
Summary: [CMake] Don't read the LOCATION property of targets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Minor
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks: 145635
  Show dependency treegraph
 
Reported: 2015-05-14 13:49 PDT by Michael Catanzaro
Modified: 2015-06-04 22:47 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.85 KB, patch)
2015-05-14 13:54 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2015-05-14 13:49:47 PDT
To silence the nasty warning we get when running cmake.

$ cmake --help-policy CMP0026
CMP0026
-------

Disallow use of the LOCATION target property.

CMake 2.8.12 and lower allowed reading the LOCATION target
property (and configuration-specific variants) to
determine the eventual location of build targets.  This relies on the
assumption that all necessary information is available at
configure-time to determine the final location and filename of the
target.  However, this property is not fully determined until later at
generate-time.  At generate time, the $<TARGET_FILE> generator
expression can be used to determine the eventual LOCATION of a target
output.

Code which reads the LOCATION target property can be ported to use the
$<TARGET_FILE> generator expression together with the file(GENERATE)
subcommand to generate a file containing the target location.

The OLD behavior for this policy is to allow reading the LOCATION
properties from build-targets.  The NEW behavior for this policy is to
not to allow reading the LOCATION properties from build-targets.

This policy was introduced in CMake version 3.0.  CMake version
3.2.2 warns when the policy is not set and uses OLD behavior.  Use
the cmake_policy command to set it to OLD or NEW explicitly.
Comment 1 Michael Catanzaro 2015-05-14 13:54:38 PDT
Created attachment 253142 [details]
Patch
Comment 2 Martin Robinson 2015-05-14 14:07:43 PDT
Comment on attachment 253142 [details]
Patch

Cleaner too. Nice.
Comment 3 WebKit Commit Bot 2015-05-14 15:30:54 PDT
Comment on attachment 253142 [details]
Patch

Clearing flags on attachment: 253142

Committed r184357: <http://trac.webkit.org/changeset/184357>
Comment 4 WebKit Commit Bot 2015-05-14 15:30:57 PDT
All reviewed patches have been landed.  Closing bug.