Bug 145534 - Web Inspector: Pause/resume button in the debugger dashboard is vertically misaligned
Summary: Web Inspector: Pause/resume button in the debugger dashboard is vertically mi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Critical
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2015-06-01 16:42 PDT by Nikita Vasilyev
Modified: 2015-06-01 18:58 PDT (History)
8 users (show)

See Also:

Attachments
[Animated GIF] Actual/expected (24.78 KB, image/gif)
2015-06-01 16:42 PDT, Nikita Vasilyev 		no flags Details
Patch (2.03 KB, patch)
2015-06-01 16:50 PDT, Nikita Vasilyev 		timothy: review+
nvasilyev: commit-queue-
Details | Formatted Diff | Diff
[Image] button background bug (3.82 KB, image/png)
2015-06-01 17:37 PDT, Nikita Vasilyev 		no flags Details
Patch (2.07 KB, patch)
2015-06-01 17:44 PDT, Nikita Vasilyev 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2015-06-01 16:42:37 PDT 
Created attachment 254024 [details]
[Animated GIF] Actual/expected

Also, when Web Inspector window is inactive, it has a border that looks out of place.

via https://bugs.webkit.org/show_bug.cgi?id=144209
Comment 1 Radar WebKit Bug Importer 2015-06-01 16:43:02 PDT 
<rdar://problem/21193048>
Comment 2 Nikita Vasilyev 2015-06-01 16:50:56 PDT 
Created attachment 254026 [details]
Patch

Generally, I consider !important as a code-smell. In this case, I think, it’s rather a simple and progmatic solution.
Comment 3 Timothy Hatcher 2015-06-01 16:51:01 PDT 
Is there also a bug tracking the overlapping function name and the arrow on the right?
Comment 4 Nikita Vasilyev 2015-06-01 16:54:36 PDT 
Not that I know of. I was about to create one.
Comment 5 Nikita Vasilyev 2015-06-01 17:33:43 PDT 
Comment on attachment 254026 [details]
Patch

It looks poor on OS X > 10.10.
Comment 6 Nikita Vasilyev 2015-06-01 17:37:46 PDT 
Created attachment 254032 [details]
[Image] button background bug
Comment 7 Nikita Vasilyev 2015-06-01 17:44:02 PDT 
Created attachment 254034 [details]
Patch
Comment 8 WebKit Commit Bot 2015-06-01 18:54:08 PDT 
Comment on attachment 254034 [details]
Patch

Clearing flags on attachment: 254034

Committed r185094: <http://trac.webkit.org/changeset/185094>
Comment 9 WebKit Commit Bot 2015-06-01 18:54:11 PDT 
All reviewed patches have been landed.  Closing bug.