Bug 145438 – Make the type profiler work with lexical scoping and add tests

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

Some small changes need to be made to how variables are linked up to their global IDs inside CodeBlock.
We will need to refer to CodeBlock's symbol table stack to find lookup variables when they're locally scoped.

[Saam Barati]

*** Bug 145958 has been marked as a duplicate of this bug. ***

[Saam Barati]

Created attachment 257298 [details]
patch

[WebKit Commit Bot]

Attachment 257298 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/bytecompiler/NodesCodegen.cpp:3276:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 257298 [details]
patch

Attachment 257298 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4857734449070080

New failing tests:
js/arguments-iterator.html
js/basic-strict-mode.html

[Build Bot]

Created attachment 257301 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 257298 [details]
patch

Attachment 257298 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4972823466475520

New failing tests:
js/arguments-iterator.html
js/basic-strict-mode.html

[Build Bot]

Created attachment 257302 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Saam Barati]

Created attachment 257656 [details]
patch

[Build Bot]

Comment on attachment 257656 [details]
patch

Attachment 257656 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4768745276833792

New failing tests:
js/arguments-iterator.html
js/basic-strict-mode.html

[Build Bot]

Created attachment 257663 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 257656 [details]
patch

Attachment 257656 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5050220253544448

New failing tests:
js/arguments-iterator.html
js/basic-strict-mode.html

[Build Bot]

Created attachment 257665 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Saam Barati]

Created attachment 257668 [details]
patch

Lets not remove a needed early return :)

[Geoffrey Garen]

Comment on attachment 257668 [details]
patch

r=me

[Saam Barati]

Fixing 32-bit build locally then will commit.

[Saam Barati]

landed in:
http://trac.webkit.org/changeset/187524