REGRESSION (r183820): webkit.org/blog/ background painting issue on reload, when the page contains videos

[Simon Fraser (smfr)]

REGRESSION (r183820): webkit.org/blog/ background painting issue on reload, when the page contains videos

[Simon Fraser (smfr)]

Created attachment 253809 [details]
Patch

[Dean Jackson]

Comment on attachment 253809 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253809&action=review

> Source/WebCore/ChangeLog:8
> +        After r183820, the media controls not longer had a wrapper that created CSS stacking context.

Typo: not longer

> Source/WebCore/rendering/RenderLayer.cpp:266
> +    , m_inResizeMode(false)

Annoying that you can't initialise this in the .h (unless I'm mistaken)

[Build Bot]

Comment on attachment 253809 [details]
Patch

Attachment 253809 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6133612588040192

New failing tests:
media/controls-layers.html

[Build Bot]

Created attachment 253814 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 253809 [details]
Patch

Attachment 253809 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5570662634618880

New failing tests:
media/controls-layers.html

[Build Bot]

Created attachment 253815 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Simon Fraser (smfr)]

https://trac.webkit.org/r184932

[Simon Fraser (smfr)]

rdar://problem/21047186

[Alexey Proskuryakov]

This broke media/controls-layers.html on most platforms, and made it assert on some. EWS told you so.

Rollout?

https://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fcontrols-layers.html

[Simon Fraser (smfr)]

I got mavericks-only test failures, and landed a mavericks result. We don't have Yosemite EWS so nothing told me about Yosemite failures. Nothing told me about assertions.

[Simon Fraser (smfr)]

The assertion is existing, and one that we've papered over by skipping tests. I guess we should just skip this test for now.

[Alexey Proskuryakov]

> nothing told me about Yosemite failures

We are supposed to run tests locally, EWS is only for platforms that we don't have access to.

> I guess we should just skip this test for now.

We?

[Alexey Proskuryakov]

I'm going to delete the test. No reason to pretend that this patch was covered by a meaningful regression test.

[Alexey Proskuryakov]

Deleted in r184943.