Bug 142142 – Rebaseline media control tests when new media control appearances are finalized

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Roger Fong]

Skipped:

media/video-no-audio.html
media/controls-strict.html
media/video-volume-slider.html
media/controls-styling.html
media/video-display-toggle.html
media/audio-controls-rendering.html
media/video-zoom-controls.html
fast/hidpi/video-controls-in-hidpi.html
media/video-controls-rendering.html
accessibility/media-element.html
media/controls-without-preload.html
media/media-controls-clone.html
fast/layers/video-layer.html
media/video-empty-source.html
media/audio-delete-while-slider-thumb-clicked.html
media/controls-after-reload.html

[Marcos Chavarría Teijeiro (irc: chavaone)]

Updated TestExpectations on GTK+ on webkit.org/b/142271

[Roger Fong]

media/nodesFromRect-shadowContent.html [ Skip ]
media/video-initially-hidden-volume-slider-up.html [ Skip ]

[Roger Fong]

(In reply to comment #1)
> Updated TestExpectations on GTK+ on webkit.org/b/142271

There are two more to skip, sorry.

[Roger Fong]

rdar://problem/20566258

[Jon Lee]

Created attachment 251105 [details]
Patch

[Jon Lee]

Comment on attachment 251105 [details]
Patch

Oops. Wrong bug. Obsoleting patch.

[Roger Fong]

Created attachment 253763 [details]
patch

[Roger Fong]

Created attachment 253765 [details]
test patch

patch to confirm remaining media control failures

[Roger Fong]

Created attachment 253776 [details]
test patch

[Roger Fong]

Reopening. Not sure why it got closed in the first place.

[Build Bot]

Comment on attachment 253776 [details]
test patch

Attachment 253776 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5277801028517888

New failing tests:
media/video-no-audio.html
media/controls-strict.html
media/controls-styling.html
media/video-volume-slider.html
fullscreen/video-controls-override.html
media/video-display-toggle.html
media/nodesFromRect-shadowContent.html
media/audio-controls-rendering.html
media/video-zoom-controls.html
media/audio-delete-while-slider-thumb-clicked.html
fast/hidpi/video-controls-in-hidpi.html
media/video-controls-rendering.html
accessibility/media-element.html
media/controls-without-preload.html
media/media-controls-clone.html
fast/layers/video-layer.html
media/video-empty-source.html
http/tests/media/hls/video-controls-live-stream.html
media/controls-after-reload.html

[Build Bot]

Created attachment 253778 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Roger Fong]

Created attachment 253782 [details]
patch

[Build Bot]

Comment on attachment 253776 [details]
test patch

Attachment 253776 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5032841863757824

New failing tests:
media/video-no-audio.html
media/controls-strict.html
media/video-volume-slider.html
fullscreen/video-controls-override.html
media/video-display-toggle.html
media/nodesFromRect-shadowContent.html
media/audio-controls-rendering.html
media/video-zoom-controls.html
media/audio-delete-while-slider-thumb-clicked.html
fast/hidpi/video-controls-in-hidpi.html
media/video-controls-rendering.html
accessibility/media-element.html
media/controls-without-preload.html
media/media-controls-clone.html
fast/layers/video-layer.html
media/video-empty-source.html
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 253783 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 253782 [details]
patch

Attachment 253782 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4965046878732288

New failing tests:
media/video-no-audio.html
media/video-display-toggle.html
media/audio-controls-rendering.html
media/video-zoom-controls.html
media/controls-without-preload.html
media/audio-delete-while-slider-thumb-clicked.html

[Build Bot]

Created attachment 253785 [details]
Archive of layout-test-results from ews102 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 253782 [details]
patch

Attachment 253782 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6139042903097344

New failing tests:
media/video-no-audio.html
media/video-display-toggle.html
media/audio-controls-rendering.html
media/video-zoom-controls.html
media/controls-without-preload.html
media/audio-delete-while-slider-thumb-clicked.html

[Build Bot]

Created attachment 253786 [details]
Archive of layout-test-results from ews104 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Darin Adler]

Comment on attachment 253782 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=253782&action=review

Looks like the tests are failing on the bots, so please don’t land this patch until that is resolved.

> LayoutTests/media/video-no-audio.html:8
> +                window.internals.settings.setWirelessPlaybackDisabled(true);

No need for window. on this line.

> LayoutTests/media/video-paint-test.js:14
> +        window.internals.settings.setWirelessPlaybackDisabled(true);

No need for window. on this line.

> LayoutTests/media/video-paint-test.js:25
> +            window.testRunner.notifyDone();

No need for window. on this line.

[Roger Fong]

Created attachment 253862 [details]
patch

[Build Bot]

Comment on attachment 253862 [details]
patch

Attachment 253862 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6365642156408832

New failing tests:
media/video-display-toggle.html
media/video-no-audio.html
media/controls-without-preload.html
media/audio-controls-rendering.html

[Build Bot]

Created attachment 253865 [details]
Archive of layout-test-results from ews101 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 253862 [details]
patch

Attachment 253862 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5966691234217984

New failing tests:
media/video-display-toggle.html
media/video-no-audio.html
media/controls-without-preload.html
media/audio-controls-rendering.html

[Build Bot]

Created attachment 253868 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Simon Fraser (smfr)]

Isn't this blocked by the same assertion that was mentioned in https://bugs.webkit.org/show_bug.cgi?id=145420#c9 but isn't covered by any bug?

[Roger Fong]

Simon says that video control tests cause assertion failures right now so I'll have to hold off on landing any rebaseline changes.

[Simon Fraser (smfr)]

Roger, please try to reproduce the assertion, and file a bug on it.

[Roger Fong]

Created attachment 253931 [details]
patch

[Roger Fong]

This patch probably won't pass until z-index: 0 is put back on the media controls panel and https://bugs.webkit.org/show_bug.cgi?id=145453 is fixed.

[Build Bot]

Comment on attachment 253931 [details]
patch

Attachment 253931 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4515398162579456

New failing tests:
media/video-no-audio.html
media/controls-strict.html
media/video-volume-slider.html
media/controls-styling.html
media/video-display-toggle.html
media/audio-controls-rendering.html
media/video-zoom-controls.html
media/video-controls-rendering.html
media/controls-without-preload.html
media/media-controls-clone.html
media/video-empty-source.html
media/audio-delete-while-slider-thumb-clicked.html
media/controls-after-reload.html

[Build Bot]

Created attachment 253936 [details]
Archive of layout-test-results from ews103 for mac-mavericks

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-mavericks  Platform: Mac OS X 10.9.5

[Build Bot]

Comment on attachment 253931 [details]
patch

Attachment 253931 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5079506683428864

New failing tests:
media/video-no-audio.html
media/controls-strict.html
media/video-volume-slider.html
media/video-display-toggle.html
media/audio-controls-rendering.html
media/video-zoom-controls.html
media/video-controls-rendering.html
media/controls-without-preload.html
media/media-controls-clone.html
media/video-empty-source.html
media/audio-delete-while-slider-thumb-clicked.html

[Build Bot]

Created attachment 253938 [details]
Archive of layout-test-results from ews105 for mac-mavericks-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-mavericks-wk2  Platform: Mac OS X 10.9.5

[Simon Fraser (smfr)]

(In reply to comment #30)
> This patch probably won't pass until z-index: 0 is put back on the media

I don't think we need to put the z-index:0 back.

[Csaba Osztrogonác]

Comment on attachment 253782 [details]
patch

Cleared Darin Adler's review+ from obsolete attachment 253782 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[Eric Carlson]

Created attachment 275000 [details]
Patch for the bots to try.

[Build Bot]

Comment on attachment 275000 [details]
Patch for the bots to try.

Attachment 275000 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1050351

New failing tests:
fast/hidpi/video-controls-in-hidpi.html
http/tests/media/hls/video-controls-live-stream.html
media/controls-styling.html

[Build Bot]

Created attachment 275001 [details]
Archive of layout-test-results from ews101 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews101  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 275000 [details]
Patch for the bots to try.

Attachment 275000 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1050355

New failing tests:
fast/hidpi/video-controls-in-hidpi.html
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 275002 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 275000 [details]
Patch for the bots to try.

Attachment 275000 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1050362

New failing tests:
fast/hidpi/video-controls-in-hidpi.html
http/tests/media/hls/video-controls-live-stream.html
media/controls-styling.html

[Build Bot]

Created attachment 275003 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Eric Carlson]

Created attachment 275027 [details]
Updated patch.

[Build Bot]

Comment on attachment 275027 [details]
Updated patch.

Attachment 275027 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1055443

New failing tests:
platform/mac-yosemite/media/controls-styling.html
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 275030 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 275027 [details]
Updated patch.

Attachment 275027 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1055452

New failing tests:
platform/mac-yosemite/media/controls-styling.html
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 275031 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 275027 [details]
Updated patch.

Attachment 275027 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1055484

New failing tests:
platform/mac-yosemite/media/controls-styling.html
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 275032 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Eric Carlson]

Created attachment 275042 [details]
Another patch for the bots.

[Build Bot]

Comment on attachment 275042 [details]
Another patch for the bots.

Attachment 275042 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1057569

New failing tests:
http/tests/media/hls/video-controls-live-stream.html
media/controls-styling.html

[Build Bot]

Created attachment 275044 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 275042 [details]
Another patch for the bots.

Attachment 275042 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1057763

New failing tests:
http/tests/media/hls/video-controls-live-stream.html
media/controls-styling.html

[Build Bot]

Created attachment 275053 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Eric Carlson]

Created attachment 275092 [details]
Another updated patch.

[Build Bot]

Comment on attachment 275092 [details]
Another updated patch.

Attachment 275092 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1063391

New failing tests:
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 275094 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 275092 [details]
Another updated patch.

Attachment 275092 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1063395

New failing tests:
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 275095 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 275092 [details]
Another updated patch.

Attachment 275092 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1063409

New failing tests:
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 275096 [details]
Archive of layout-test-results from ews114 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Eric Carlson]

Created attachment 275100 [details]
YAUP

[Build Bot]

Comment on attachment 275100 [details]
YAUP

Attachment 275100 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1063961

New failing tests:
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 275105 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 275100 [details]
YAUP

Attachment 275100 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1063960

New failing tests:
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 275106 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 275100 [details]
YAUP

Attachment 275100 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/1063975

New failing tests:
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 275111 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[David Kilzer (:ddkilzer)]

Comment on attachment 275100 [details]
YAUP

View in context: https://bugs.webkit.org/attachment.cgi?id=275100&action=review

> LayoutTests/ChangeLog:23
> +        * platform/mac-yosemite/media/video-controls-live-stream-expected.txt: Added.

This should be in (missing "hls" subdirectory):

platform/mac-yosemite/media/hls/video-controls-live-stream-expected.txt

[Eric Carlson]

Created attachment 275129 [details]
Another updated patch.

[Eric Carlson]

Created attachment 275136 [details]
Updated patch

[Eric Carlson]

Created attachment 275196 [details]
Another patch.

[Eric Carlson]

Created attachment 275213 [details]
another patch for SVN

[Eric Carlson]

Created attachment 275276 [details]
Another patch for SVN

[Build Bot]

Comment on attachment 275276 [details]
Another patch for SVN

Attachment 275276 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/1075436

New failing tests:
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 275279 [details]
Archive of layout-test-results from ews100 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 275276 [details]
Another patch for SVN

Attachment 275276 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/1075432

New failing tests:
http/tests/media/hls/video-controls-live-stream.html

[Build Bot]

Created attachment 275280 [details]
Archive of layout-test-results from ews104 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Eric Carlson]

Created attachment 275281 [details]
Another patch.

[Brent Fulgham]

Comment on attachment 275281 [details]
Another patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=275281&action=review

r=me.

> LayoutTests/ChangeLog:11
> +          more deterministic.

Good idea!

[WebKit Commit Bot]

Comment on attachment 275281 [details]
Another patch.

Clearing flags on attachment: 275281

Committed r198912: <http://trac.webkit.org/changeset/198912>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.